From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Milian Wolff <milian.wolff@kdab.com>
Cc: Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
acme@kernel.org
Subject: Re: [PATCH] perf report: include partial stacks unwound with libdw
Date: Fri, 2 Jun 2017 11:59:22 -0300 [thread overview]
Message-ID: <20170602145922.GA7901@redhat.com> (raw)
In-Reply-To: <20170601210021.20046-1-milian.wolff@kdab.com>
Em Thu, Jun 01, 2017 at 11:00:21PM +0200, Milian Wolff escreveu:
> With this patch applied, the libdw unwinder will produce the same
> output as the libunwind unwinder.
> +++ b/tools/perf/util/unwind-libdw.c
> @@ -224,7 +224,7 @@ int unwind__get_entries(unwind_entry_cb_t cb, void *arg,
>
> err = dwfl_getthread_frames(ui->dwfl, thread->tid, frame_callback, ui);
>
> - if (err && !ui->max_stack)
> + if (err && ui->max_stack != max_stack)
> err = 0;
Simple enough, thanks a lot, applied!
- Arnaldo
next prev parent reply other threads:[~2017-06-02 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 21:00 [PATCH] perf report: include partial stacks unwound with libdw Milian Wolff
2017-06-02 14:59 ` Arnaldo Carvalho de Melo [this message]
2017-06-07 16:01 ` [tip:perf/urgent] perf report: Include " tip-bot for Milian Wolff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170602145922.GA7901@redhat.com \
--to=acme@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.