From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Sat, 03 Jun 2017 10:22:33 +0000 Subject: Re: [PATCH v2 1/1] w1: Add subsystem kernel public interface Message-Id: <20170603102233.GA19112@kroah.com> List-Id: References: <20170516200814.12360-1-afd@ti.com> <20170516200814.12360-2-afd@ti.com> In-Reply-To: <20170516200814.12360-2-afd@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Andrew F. Davis" Cc: Evgeniy Polyakov , Sebastian Reichel , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, May 16, 2017 at 03:08:14PM -0500, Andrew F. Davis wrote: > Like other subsystems we should be able to define slave devices outside > of the w1 directory. To do this we move public facing interface > definitions to include/linux/w1.h and rename the internal definition > file to w1_internal.h. > > As w1_family.h and w1_int.h contained almost entirely public > driver interface definitions we simply removed these files and > moved the remaining definitions into w1_internal.h. > > With this we can now start to move slave devices out of w1/slaves and > into the subsystem based on the function they implement, again like > other drivers. > > Signed-off-by: Andrew F. Davis > Reviewed-by: Sebastian Reichel This breaks the build for me: CC [M] drivers/power/supply/ds2760_battery.o drivers/power/supply/ds2760_battery.c:31:10: fatal error: ../../w1/w1.h: No such file or directory #include "../../w1/w1.h" ^~~~~~~~~~~~~~~ compilation terminated. So there was w1 drivers outside of the drivers/w1/ directory :) Please fix and resend. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751369AbdFCOPw (ORCPT ); Sat, 3 Jun 2017 10:15:52 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54428 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750997AbdFCOPv (ORCPT ); Sat, 3 Jun 2017 10:15:51 -0400 Date: Sat, 3 Jun 2017 19:22:33 +0900 From: Greg Kroah-Hartman To: "Andrew F. Davis" Cc: Evgeniy Polyakov , Sebastian Reichel , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] w1: Add subsystem kernel public interface Message-ID: <20170603102233.GA19112@kroah.com> References: <20170516200814.12360-1-afd@ti.com> <20170516200814.12360-2-afd@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170516200814.12360-2-afd@ti.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 16, 2017 at 03:08:14PM -0500, Andrew F. Davis wrote: > Like other subsystems we should be able to define slave devices outside > of the w1 directory. To do this we move public facing interface > definitions to include/linux/w1.h and rename the internal definition > file to w1_internal.h. > > As w1_family.h and w1_int.h contained almost entirely public > driver interface definitions we simply removed these files and > moved the remaining definitions into w1_internal.h. > > With this we can now start to move slave devices out of w1/slaves and > into the subsystem based on the function they implement, again like > other drivers. > > Signed-off-by: Andrew F. Davis > Reviewed-by: Sebastian Reichel This breaks the build for me: CC [M] drivers/power/supply/ds2760_battery.o drivers/power/supply/ds2760_battery.c:31:10: fatal error: ../../w1/w1.h: No such file or directory #include "../../w1/w1.h" ^~~~~~~~~~~~~~~ compilation terminated. So there was w1 drivers outside of the drivers/w1/ directory :) Please fix and resend. thanks, greg k-h