From: Jonathan Cameron <jic23@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
Sebastian Reichel <sre@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>
Cc: J Keerthy <j-keerthy@ti.com>,
linux-iio@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] iio: adc: twl4030: Unexport twl4030_madc_conversion()
Date: Sat, 3 Jun 2017 10:37:37 +0100 [thread overview]
Message-ID: <20170603103737.139206f6@kernel.org> (raw)
In-Reply-To: <7eb96b68-71a7-361f-d14c-542a823f96b8@kernel.org>
On Sun, 30 Apr 2017 17:35:47 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> On 27/04/17 16:30, Sebastian Reichel wrote:
> > All madc users have been converted to IIO API, so drop the
> > legacy API. The function is still used inside of the driver.
> >
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> Acked-by: Jonathan Cameron <jic23@kernel.org>
Applied to the togreg branch of iio.git and pushed out
as testing for the autobuilders to play with them.
thanks,
Jonathan
> > ---
> > drivers/iio/adc/twl4030-madc.c | 5 +++--
> > include/linux/i2c/twl4030-madc.h | 2 --
> > 2 files changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c
> > index 88e44066ef82..be60f76d1a50 100644
> > --- a/drivers/iio/adc/twl4030-madc.c
> > +++ b/drivers/iio/adc/twl4030-madc.c
> > @@ -72,6 +72,8 @@ struct twl4030_madc_data {
> > u8 isr;
> > };
> >
> > +static int twl4030_madc_conversion(struct twl4030_madc_request *req);
> > +
> > static int twl4030_madc_read(struct iio_dev *iio_dev,
> > const struct iio_chan_spec *chan,
> > int *val, int *val2, long mask)
> > @@ -568,7 +570,7 @@ static int twl4030_madc_wait_conversion_ready(struct twl4030_madc_data *madc,
> > * be a negative error value in the corresponding array element.
> > * returns 0 if succeeds else error value
> > */
> > -int twl4030_madc_conversion(struct twl4030_madc_request *req)
> > +static int twl4030_madc_conversion(struct twl4030_madc_request *req)
> > {
> > const struct twl4030_madc_conversion_method *method;
> > int ret;
> > @@ -640,7 +642,6 @@ int twl4030_madc_conversion(struct twl4030_madc_request *req)
> >
> > return ret;
> > }
> > -EXPORT_SYMBOL_GPL(twl4030_madc_conversion);
> >
> > /**
> > * twl4030_madc_set_current_generator() - setup bias current
> > diff --git a/include/linux/i2c/twl4030-madc.h b/include/linux/i2c/twl4030-madc.h
> > index 0c919ebb31e0..be9260e261ac 100644
> > --- a/include/linux/i2c/twl4030-madc.h
> > +++ b/include/linux/i2c/twl4030-madc.h
> > @@ -141,6 +141,4 @@ struct twl4030_madc_user_parms {
> > int status;
> > u16 result;
> > };
> > -
> > -int twl4030_madc_conversion(struct twl4030_madc_request *conv);
> > #endif
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-03 9:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 15:30 [PATCH 0/7] twl4030-madc cleanup Sebastian Reichel
2017-04-27 15:30 ` [PATCH 1/7] hwmon: twl4030-madc: drop driver Sebastian Reichel
2017-04-27 16:51 ` Guenter Roeck
2017-04-30 16:41 ` Jonathan Cameron
2017-04-30 18:46 ` Guenter Roeck
2017-05-01 9:27 ` Sebastian Reichel
2017-05-01 10:38 ` Wolfram Sang
2017-04-27 15:30 ` [PATCH 2/7] power: supply: avoid unused twl4030-madc.h Sebastian Reichel
2017-05-01 11:51 ` Sebastian Reichel
2017-04-27 15:30 ` [PATCH 3/7] iio: adc: twl4030: Drop twl4030_get_madc_conversion() Sebastian Reichel
2017-04-30 16:35 ` Jonathan Cameron
2017-06-03 9:36 ` Jonathan Cameron
2017-04-27 15:30 ` [PATCH 4/7] iio: adc: twl4030: Unexport twl4030_madc_conversion() Sebastian Reichel
2017-04-30 16:35 ` Jonathan Cameron
2017-06-03 9:37 ` Jonathan Cameron [this message]
2017-04-27 15:30 ` [PATCH 5/7] iio: adc: twl4030: Drop struct twl4030_madc_user_parms Sebastian Reichel
2017-06-03 9:40 ` Jonathan Cameron
2017-04-27 15:30 ` [PATCH 6/7] iio: adc: twl4030: Remove twl4030_madc_request.func_cb Sebastian Reichel
2017-04-30 16:37 ` Jonathan Cameron
2017-04-27 15:30 ` [PATCH 7/7] iio: adc: twl4030: Fold twl4030-madc.h into driver Sebastian Reichel
2017-04-30 16:38 ` Jonathan Cameron
2017-06-03 9:45 ` Jonathan Cameron
2017-05-20 16:54 ` [PATCH 0/7] twl4030-madc cleanup Sebastian Reichel
2017-05-20 17:57 ` Jonathan Cameron
2017-06-03 9:43 ` Jonathan Cameron
2017-06-06 8:23 ` Sebastian Reichel
2017-06-11 15:04 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170603103737.139206f6@kernel.org \
--to=jic23@kernel.org \
--cc=j-keerthy@ti.com \
--cc=jdelvare@suse.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pmeerw@pmeerw.net \
--cc=sebastian.reichel@collabora.co.uk \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.