From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751274AbdFEPUn (ORCPT <rfc822;w@1wt.eu>);
        Mon, 5 Jun 2017 11:20:43 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:55530 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751077AbdFEPUl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 5 Jun 2017 11:20:41 -0400
Date: Mon, 5 Jun 2017 17:20:36 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
        Lukas Wunner <lukas@wunner.de>,
        Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <yehezkel.bernat@intel.com>,
        Amir Levy <amir.jer.levy@intel.com>, Andy Lutomirski <luto@kernel.org>,
        Mario.Limonciello@dell.com, Jared.Dominguez@dell.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs
Message-ID: <20170605152036.GA19810@kroah.com>
References: <20170602140524.23367-1-mika.westerberg@linux.intel.com>
 <20170602140524.23367-20-mika.westerberg@linux.intel.com>
 <20170605081437.GA7519@wunner.de>
 <20170605093249.GK3454@lahna.fi.intel.com>
 <20170605120756.GA7793@wunner.de>
 <20170605125507.GL3454@lahna.fi.intel.com>
 <20170605133334.GM3454@lahna.fi.intel.com>
 <1496672494.22624.4.camel@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1496672494.22624.4.camel@linux.intel.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 05, 2017 at 05:21:34PM +0300, Andy Shevchenko wrote:
> On Mon, 2017-06-05 at 16:33 +0300, Mika Westerberg wrote:
> > On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote:
> > > > 
> 
> > It turns out that this is not too big change after all so I think it
> > can
> > be included in the ICM patch if you want.
> > 
> > Basically we would have module parameter:
> > 
> > 	cm=auto|native|icm
> > 
> > where auto is the default.
> > 
> > Does that work?
> 
> 
> I remember Greg is opposite to being fan of module parameters in new
> code, so, please, if you are still going to do that, do it a separate
> patch which will be last in the series and can be discussed separately
> w.o. preventing everything else being applied.

Yes, you should never need module parameters in "modern" code.  As no
one will ever set them, or know what to do here.  Make it "automatic"
please.

thanks,

greg k-h