Re: [Qemu-devel] [PATCH v2 1/1] s390x: vmstatify config migration for virtio-ccw

[Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>]

* Eric Blake <eblake@redhat.com> [2017-06-05 07:19:14 -0500]:

Hi Eric,

> On 06/04/2017 10:09 PM, Dong Jia Shi wrote:
> > * Halil Pasic <pasic@linux.vnet.ibm.com> [2017-06-02 16:05:31 +0200]:
> > 
> > Hi Halil,
> > 
> > Sorry for the late show up. I just found some nits, which could be
> > ignored for me.
> > 
> >> Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for
> >> flexibility (extending using subsections) and for fun.
> >>
> >> To achieve this we need to hack the config_vector, which is VirtIODevice
> >> (that is common virtio) state, in the middle of the VirtioCcwDevice state
> >> representation.  This is somewhat ugly, but we have no choice because the
> >                  ^^
> > Nit:-------------++
> 
> What's wrong here?  Two spaces between sentences is a common
> typographical convention 
Thanks for letting me learn this. I didn't know this interesting
knowledge before I saw this comment and searched in the Internet:
https://en.wikipedia.org/wiki/Sentence_spacing

> (true, the codebase is inconsistent on whether sentences are separated
> with one or two spaces, but that's all the more reason to realize that
> since we don't have a consistent standard, it is just churn to change
> from one style to the other)
I was thinking 1) inconsistence is strange and unwelcome, and 2) the
inconsistence here may be something that Halil did not intend to have.

Since it's a common typographical convention, and I'm not a native
English speaker. I will follow your opinion.

> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org
> 



-- 
Dong Jia Shi