From: Christoph Hellwig <hch@infradead.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Vinayak Holikatti <vinholikatti@gmail.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Szymon Mielczarek <szymonx.mielczarek@intel.com>,
Michal Potomski <michalx.potomski@intel.com>,
Grzegorz Janca <grzegorz.janca@intel.com>
Subject: Re: [PATCH 2/2] scsi: ufshcd-intel-pci: Add PCI driver for Intel Host controllers
Date: Tue, 6 Jun 2017 00:07:57 -0700 [thread overview]
Message-ID: <20170606070757.GA1748@infradead.org> (raw)
In-Reply-To: <1496651815-13416-3-git-send-email-adrian.hunter@intel.com>
> +#define PCI_CLASS_STORAGE_UFSHCI 0x010901
should me move to pci_ids.h
> +
> +#define UFSHCD_INTEL_PCI_UFSHCI_DEVICE() { \
> + .vendor = PCI_VENDOR_ID_INTEL, \
> + .device = PCI_ANY_ID, \
> + .subvendor = PCI_ANY_ID, \
> + .subdevice = PCI_ANY_ID, \
> + .class = PCI_CLASS_STORAGE_UFSHCI, \
> + .class_mask = ~0, \
> +}
Please don't use a macro for this. And matching for any possible
future intel device with the classcode looks a little sketchy to
me to be honest.
next prev parent reply other threads:[~2017-06-06 7:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 8:36 [PATCH 0/2] scsi: ufs: Add PCI driver for Intel Host controllers Adrian Hunter
2017-06-05 8:36 ` [PATCH 1/2] scsi: ufs: Tidy clocks list head usage Adrian Hunter
2017-06-05 20:37 ` Subhash Jadavani
2017-06-06 0:57 ` Martin K. Petersen
2017-06-05 8:36 ` [PATCH 2/2] scsi: ufshcd-intel-pci: Add PCI driver for Intel Host controllers Adrian Hunter
2017-06-05 20:42 ` Subhash Jadavani
2017-06-06 6:48 ` [PATCH V2 1/2] scsi: ufs: Tidy clocks list head usage Adrian Hunter
2017-06-06 6:48 ` [PATCH V2 2/2] scsi: ufshcd-intel-pci: Add PCI driver for Intel Host controllers Adrian Hunter
2017-06-06 6:50 ` [PATCH V2 1/2] scsi: ufs: Tidy clocks list head usage Adrian Hunter
2017-06-06 7:07 ` Christoph Hellwig [this message]
2017-06-06 9:08 ` [PATCH V3 2/2] scsi: ufshcd-intel-pci: Add PCI driver for Intel Host controllers Adrian Hunter
2017-06-06 10:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606070757.GA1748@infradead.org \
--to=hch@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=grzegorz.janca@intel.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michalx.potomski@intel.com \
--cc=szymonx.mielczarek@intel.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.