* [PATCH] drm/i915: s/fbc_fc/fbc_false_color/
@ 2017-06-06 12:44 ville.syrjala
2017-06-06 15:15 ` Vivi, Rodrigo
0 siblings, 1 reply; 3+ messages in thread
From: ville.syrjala @ 2017-06-06 12:44 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
We're not that short on characters that we can't spell out
"false_color". Saves me from figuring out what "fc" means
the next time look at the code.
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 8fdb911344b3..a6ba2100bb88 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -1694,7 +1694,7 @@ static int i915_fbc_status(struct seq_file *m, void *unused)
return 0;
}
-static int i915_fbc_fc_get(void *data, u64 *val)
+static int i915_fbc_false_color_get(void *data, u64 *val)
{
struct drm_i915_private *dev_priv = data;
@@ -1706,7 +1706,7 @@ static int i915_fbc_fc_get(void *data, u64 *val)
return 0;
}
-static int i915_fbc_fc_set(void *data, u64 val)
+static int i915_fbc_false_color_set(void *data, u64 val)
{
struct drm_i915_private *dev_priv = data;
u32 reg;
@@ -1727,8 +1727,8 @@ static int i915_fbc_fc_set(void *data, u64 val)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(i915_fbc_fc_fops,
- i915_fbc_fc_get, i915_fbc_fc_set,
+DEFINE_SIMPLE_ATTRIBUTE(i915_fbc_false_color_fops,
+ i915_fbc_false_color_get, i915_fbc_false_color_set,
"%llu\n");
static int i915_ips_status(struct seq_file *m, void *unused)
@@ -4869,7 +4869,7 @@ static const struct i915_debugfs_files {
{"i915_pri_wm_latency", &i915_pri_wm_latency_fops},
{"i915_spr_wm_latency", &i915_spr_wm_latency_fops},
{"i915_cur_wm_latency", &i915_cur_wm_latency_fops},
- {"i915_fbc_false_color", &i915_fbc_fc_fops},
+ {"i915_fbc_false_color", &i915_fbc_false_color_fops},
{"i915_dp_test_data", &i915_displayport_test_data_fops},
{"i915_dp_test_type", &i915_displayport_test_type_fops},
{"i915_dp_test_active", &i915_displayport_test_active_fops},
--
2.13.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: s/fbc_fc/fbc_false_color/
2017-06-06 12:44 [PATCH] drm/i915: s/fbc_fc/fbc_false_color/ ville.syrjala
@ 2017-06-06 15:15 ` Vivi, Rodrigo
2017-06-06 16:41 ` Ville Syrjälä
0 siblings, 1 reply; 3+ messages in thread
From: Vivi, Rodrigo @ 2017-06-06 15:15 UTC (permalink / raw)
To: ville.syrjala@linux.intel.com; +Cc: intel-gfx@lists.freedesktop.org
On Tue, 2017-06-06 at 15:44 +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We're not that short on characters that we can't spell out
> "false_color". Saves me from figuring out what "fc" means
> the next time look at the code.
Yeap, even I took a while to remember what was fc last time that I saw
this...
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 8fdb911344b3..a6ba2100bb88 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -1694,7 +1694,7 @@ static int i915_fbc_status(struct seq_file *m, void *unused)
> return 0;
> }
>
> -static int i915_fbc_fc_get(void *data, u64 *val)
> +static int i915_fbc_false_color_get(void *data, u64 *val)
> {
> struct drm_i915_private *dev_priv = data;
>
> @@ -1706,7 +1706,7 @@ static int i915_fbc_fc_get(void *data, u64 *val)
> return 0;
> }
>
> -static int i915_fbc_fc_set(void *data, u64 val)
> +static int i915_fbc_false_color_set(void *data, u64 val)
> {
> struct drm_i915_private *dev_priv = data;
> u32 reg;
> @@ -1727,8 +1727,8 @@ static int i915_fbc_fc_set(void *data, u64 val)
> return 0;
> }
>
> -DEFINE_SIMPLE_ATTRIBUTE(i915_fbc_fc_fops,
> - i915_fbc_fc_get, i915_fbc_fc_set,
> +DEFINE_SIMPLE_ATTRIBUTE(i915_fbc_false_color_fops,
> + i915_fbc_false_color_get, i915_fbc_false_color_set,
> "%llu\n");
>
> static int i915_ips_status(struct seq_file *m, void *unused)
> @@ -4869,7 +4869,7 @@ static const struct i915_debugfs_files {
> {"i915_pri_wm_latency", &i915_pri_wm_latency_fops},
> {"i915_spr_wm_latency", &i915_spr_wm_latency_fops},
> {"i915_cur_wm_latency", &i915_cur_wm_latency_fops},
> - {"i915_fbc_false_color", &i915_fbc_fc_fops},
> + {"i915_fbc_false_color", &i915_fbc_false_color_fops},
> {"i915_dp_test_data", &i915_displayport_test_data_fops},
> {"i915_dp_test_type", &i915_displayport_test_type_fops},
> {"i915_dp_test_active", &i915_displayport_test_active_fops},
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: s/fbc_fc/fbc_false_color/
2017-06-06 15:15 ` Vivi, Rodrigo
@ 2017-06-06 16:41 ` Ville Syrjälä
0 siblings, 0 replies; 3+ messages in thread
From: Ville Syrjälä @ 2017-06-06 16:41 UTC (permalink / raw)
To: Vivi, Rodrigo; +Cc: intel-gfx@lists.freedesktop.org
On Tue, Jun 06, 2017 at 03:15:09PM +0000, Vivi, Rodrigo wrote:
> On Tue, 2017-06-06 at 15:44 +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > We're not that short on characters that we can't spell out
> > "false_color". Saves me from figuring out what "fc" means
> > the next time look at the code.
>
> Yeap, even I took a while to remember what was fc last time that I saw
> this...
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Pushed to dinq. Thanks for the review.
>
> >
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_debugfs.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > index 8fdb911344b3..a6ba2100bb88 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -1694,7 +1694,7 @@ static int i915_fbc_status(struct seq_file *m, void *unused)
> > return 0;
> > }
> >
> > -static int i915_fbc_fc_get(void *data, u64 *val)
> > +static int i915_fbc_false_color_get(void *data, u64 *val)
> > {
> > struct drm_i915_private *dev_priv = data;
> >
> > @@ -1706,7 +1706,7 @@ static int i915_fbc_fc_get(void *data, u64 *val)
> > return 0;
> > }
> >
> > -static int i915_fbc_fc_set(void *data, u64 val)
> > +static int i915_fbc_false_color_set(void *data, u64 val)
> > {
> > struct drm_i915_private *dev_priv = data;
> > u32 reg;
> > @@ -1727,8 +1727,8 @@ static int i915_fbc_fc_set(void *data, u64 val)
> > return 0;
> > }
> >
> > -DEFINE_SIMPLE_ATTRIBUTE(i915_fbc_fc_fops,
> > - i915_fbc_fc_get, i915_fbc_fc_set,
> > +DEFINE_SIMPLE_ATTRIBUTE(i915_fbc_false_color_fops,
> > + i915_fbc_false_color_get, i915_fbc_false_color_set,
> > "%llu\n");
> >
> > static int i915_ips_status(struct seq_file *m, void *unused)
> > @@ -4869,7 +4869,7 @@ static const struct i915_debugfs_files {
> > {"i915_pri_wm_latency", &i915_pri_wm_latency_fops},
> > {"i915_spr_wm_latency", &i915_spr_wm_latency_fops},
> > {"i915_cur_wm_latency", &i915_cur_wm_latency_fops},
> > - {"i915_fbc_false_color", &i915_fbc_fc_fops},
> > + {"i915_fbc_false_color", &i915_fbc_false_color_fops},
> > {"i915_dp_test_data", &i915_displayport_test_data_fops},
> > {"i915_dp_test_type", &i915_displayport_test_type_fops},
> > {"i915_dp_test_active", &i915_displayport_test_active_fops},
>
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-06 16:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-06 12:44 [PATCH] drm/i915: s/fbc_fc/fbc_false_color/ ville.syrjala
2017-06-06 15:15 ` Vivi, Rodrigo
2017-06-06 16:41 ` Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.