From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: Re: [PATCH v2] net/ixgbe: enable PTYPE offload for x86 vector PMD Date: Tue, 6 Jun 2017 17:45:26 +0200 Message-ID: <20170606174526.1205227d@platinum> References: <1496273426-15176-1-git-send-email-qi.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: konstantin.ananyev@intel.com, helin.zhang@intel.com, wenzhuo.lu@intel.com, ray.kinsella@intel.com, dev@dpdk.org To: Qi Zhang Return-path: Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id 57612532D for ; Tue, 6 Jun 2017 17:45:30 +0200 (CEST) Received: by mail-wr0-f180.google.com with SMTP id q97so55956893wrb.2 for ; Tue, 06 Jun 2017 08:45:30 -0700 (PDT) In-Reply-To: <1496273426-15176-1-git-send-email-qi.z.zhang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Qi, On Wed, 31 May 2017 19:30:26 -0400, Qi Zhang wrote: > Hardware PTYPE in Rx desc will be parsed to fill > mbuf's packet_type. >=20 > Signed-off-by: Ray Kinsella > Signed-off-by: Qi Zhang > --- >=20 > v2: > - replace large macro that parse packet type with inline function > - fix couple check patch issues. >=20 > drivers/net/ixgbe/ixgbe_ethdev.c | 8 + > drivers/net/ixgbe/ixgbe_rxtx.c | 623 ++++++++++++++-------------= ------ > drivers/net/ixgbe/ixgbe_rxtx.h | 92 +++++ > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 65 ++++ > 4 files changed, 434 insertions(+), 354 deletions(-) >=20 I tried to compile your patch with RTE_MACHINE=3Ddefault, and I have the following compilation error: gcc -Wp,-MD,./.ixgbe_rxtx_vec_sse.o.d.tmp -m64 -pthread -march=3Dcore2 -D= RTE_MACHINE_CPUFLAG_SSE -DRTE_MACHINE_CPUFLAG_SSE2 -DRTE_MACHINE_CPUFLAG_SS= E3 -DRTE_MACHINE_CPUFLAG_SSSE3 -I/home/user/dpdk.org/build/include -includ= e /home/user/dpdk.org/build/include/rte_config.h -O3 -W -Wall -Wstrict-prot= otypes -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -= Wpointer-arith -Wcast-align -Wnested-externs -Wcast-qual -Wformat-nonlitera= l -Wformat-security -Wundef -Wwrite-strings -Werror -Wno-deprecated -o i= xgbe_rxtx_vec_sse.o -c /home/user/dpdk.org/drivers/net/ixgbe/ixgbe_rxtx_vec= _sse.c=20 In file included from /usr/lib/gcc/x86_64-linux-gnu/6/include/x86intrin.h:4= 3:0, from /home/user/dpdk.org/build/include/rte_vect.h:70, from /home/user/dpdk.org/build/include/rte_memcpy.h:46, from /home/user/dpdk.org/build/include/rte_ether.h:50, from /home/user/dpdk.org/build/include/rte_ethdev.h:185, from /home/user/dpdk.org/drivers/net/ixgbe/ixgbe_rxtx_vec_= sse.c:35: /home/user/dpdk.org/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c: In function =E2= =80=98desc_to_ptype_v=E2=80=99: /usr/lib/gcc/x86_64-linux-gnu/6/include/smmintrin.h:447:1: error: inlining = failed in call to always_inline =E2=80=98_mm_extract_epi32=E2=80=99: target= specific option mismatch _mm_extract_epi32 (__m128i __X, const int __N) ^~~~~~~~~~~~~~~~~ /home/user/dpdk.org/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:300:13: note: ca= lled from here pkt_info =3D _mm_extract_epi32(ptype0, 3); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /usr/lib/gcc/x86_64-linux-gnu/6/include/x86intrin.h:4= 3:0, from /home/user/dpdk.org/build/include/rte_vect.h:70, from /home/user/dpdk.org/build/include/rte_memcpy.h:46, from /home/user/dpdk.org/build/include/rte_ether.h:50, from /home/user/dpdk.org/build/include/rte_ethdev.h:185, from /home/user/dpdk.org/drivers/net/ixgbe/ixgbe_rxtx_vec_= sse.c:35: [...] To reproduce: make config T=3Dx86_64-native-linuxapp-gcc sed -i 's,CONFIG_RTE_MACHINE=3D"native",CONFIG_RTE_MACHINE=3D"default",' b= uild/.config make Do we still want to support the core2 target? Thanks, Olivier