All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Benjamin Coddington <bcodding@redhat.com>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: GSS sequence number window
Date: Tue, 6 Jun 2017 16:15:04 -0400	[thread overview]
Message-ID: <20170606201504.GH13376@fieldses.org> (raw)
In-Reply-To: <4D542D55-DCBA-4838-9DB2-B76B4068783E@oracle.com>

On Tue, Jun 06, 2017 at 03:45:59PM -0400, Chuck Lever wrote:
> 
> > On Jun 6, 2017, at 3:41 PM, J. Bruce Fields <bfields@fieldses.org> wrote:
> > 
> > On Tue, Jun 06, 2017 at 03:35:23PM -0400, Chuck Lever wrote:
> >> I filed https://bugzilla.linux-nfs.org/show_bug.cgi?id=306
> >> 
> >> To check memory allocation latency, I could always construct
> >> a framework around kmalloc and alloc_page.
> >> 
> >> 
> >> I've also found some bad behavior around proto=rdma,sec=krb5i.
> >> When I run a heavy I/O workload (fio, for example), every so
> >> often a read operation fails with EIO. I dug into it a little
> >> and MIC verification fails for these replies on the client.
> > 
> > Do we still have the problem that the read data can change between the
> > time we calculate the MIC and the time we transmit the data to the
> > client?
> 
> I don't see a problem with krb5p, which, if IIUC, would also
> fall victim to this situation, unless there is much stricter
> request serialization going on with krb5p.

We turn off zero-copy by clearing RQ_SPLICE_OK in the krb5p case.

> Even so, how would I detect if this issue was present?

Good question.  If you knew the data and mic in the bad case, and had
some way to guess what the previous data might have been based on what
you knew about the test, then you could try mic's of likely older
versions of the data and see if you get a match....  That sounds hard.

--b.

  reply	other threads:[~2017-06-06 20:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30 18:58 GSS sequence number window Chuck Lever
2017-05-30 19:34 ` J. Bruce Fields
2017-05-30 20:11   ` Benjamin Coddington
2017-05-31 19:22     ` J. Bruce Fields
2017-05-31 20:27       ` Chuck Lever
2017-06-06 19:35         ` Chuck Lever
2017-06-06 19:41           ` J. Bruce Fields
2017-06-06 19:45             ` Chuck Lever
2017-06-06 20:15               ` J. Bruce Fields [this message]
2017-06-06 20:16                 ` Chuck Lever
2017-06-06 20:23                   ` J. Bruce Fields
2017-06-06 20:54                     ` Chuck Lever
2017-06-06 20:56                       ` J. Bruce Fields
2017-05-30 21:03   ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170606201504.GH13376@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=bcodding@redhat.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.