From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: ls1088a: update sata node
Date: Wed, 7 Jun 2017 14:02:26 +0800 [thread overview]
Message-ID: <20170607060224.GE31070@dragon> (raw)
In-Reply-To: <HE1PR0402MB2828FDB61A1AD186E3802962F3C80@HE1PR0402MB2828.eurprd04.prod.outlook.com>
On Wed, Jun 07, 2017 at 03:41:03AM +0000, Andy Tang wrote:
> A: ls1088 is not a new compatible. For ls1088 soc, it should be "fsl,ls1088a-ahci".
Have you added the compatible support into kernel driver and bindings
doc?
> Previously, we thought ls1088 is compatible with ls1043, so that we defined compatible string as: "fsl,ls1088a-ahci", "fsl,ls1043a-ahci"; By doing so, we can reuse code.
>
> Now we found they are not 100% compatible because ECC register address is different. ECC register doesn't belong to SATA IP. It is a global register which controls many IPs. SATA ecc is controlled by only one bit in this register.
>
Okay, understood. It sounds like the register should belong to a global
system controller. If the SATA driver was designed to parse the ECC
register and bit from device tree with a phandle pointing to that
system controller, we do not need to have so many compatibles for the
same SATA IP.
Shawn
next prev parent reply other threads:[~2017-06-07 6:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 7:45 [PATCH] arm64: dts: ls1088a: update sata node Yuantian Tang
2017-06-05 15:14 ` Shawn Guo
2017-06-07 2:38 ` Andy Tang
2017-06-07 3:26 ` Shawn Guo
2017-06-07 3:41 ` Andy Tang
2017-06-07 6:02 ` Shawn Guo [this message]
2017-06-07 6:10 ` Andy Tang
2017-06-07 6:32 ` Andy Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607060224.GE31070@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.