From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Masaki Ota <masaki.ota@jp.alps.com>,
Damjan Georgievski <gdamjan@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: Trackpoint on Thinkpad X1 Carbon (5th gen)
Date: Tue, 6 Jun 2017 23:36:44 -0700 [thread overview]
Message-ID: <20170607063644.GD23434@dtor-ws> (raw)
In-Reply-To: <20170606174154.GA19288@dtor-ws>
On Tue, Jun 06, 2017 at 10:41:54AM -0700, Dmitry Torokhov wrote:
> On Tue, Jun 06, 2017 at 09:49:09AM +0200, Benjamin Tissoires wrote:
> > Damjan, would you mind trying the following change:
> > diff --git a/drivers/input/rmi4/rmi_f03.c b/drivers/input/rmi4/rmi_f03.c
> > index 77dad04..ad71a5e 100644
> > --- a/drivers/input/rmi4/rmi_f03.c
> > +++ b/drivers/input/rmi4/rmi_f03.c
> > @@ -146,7 +146,7 @@ static int rmi_f03_register_pt(struct f03_data *f03)
> > if (!serio)
> > return -ENOMEM;
> >
> > - serio->id.type = SERIO_8042;
> > + serio->id.type = SERIO_PS_PSTHRU;
>
> No, you do not want to do this. psmouse-base has more logic than just
> selecting protocols to probe keyed off SERIO_PS_PSTHRU.
Actually, you are right, it will work, since psmouse-base.c also checks
if serio has a parent before activating/deactivating passthrough logic,
and F03-backed serio port will not have a serio parent.
Thanks.
--
Dmitry
prev parent reply other threads:[~2017-06-07 6:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 20:12 Trackpoint on Thinkpad X1 Carbon (5th gen) Damjan Georgievski
2017-05-23 18:12 ` Damjan Georgievski
2017-05-30 17:24 ` Dmitry Torokhov
2017-06-02 10:46 ` Damjan Georgievski
2017-06-05 0:52 ` Masaki Ota
2017-06-06 7:49 ` Benjamin Tissoires
2017-06-06 17:28 ` Damjan Georgievski
2017-06-06 17:41 ` Dmitry Torokhov
2017-06-07 1:18 ` Masaki Ota
2017-06-07 6:34 ` Dmitry Torokhov
2017-06-07 6:36 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607063644.GD23434@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=gdamjan@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=masaki.ota@jp.alps.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.