From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lennart Poettering Subject: Re: [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI Date: Wed, 7 Jun 2017 09:48:48 +0200 Message-ID: <20170607074848.GE27006@gardel-login> References: <20170601184632.2980-1-benjamin.tissoires@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170601184632.2980-1-benjamin.tissoires@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: systemd-devel-bounces@lists.freedesktop.org Sender: "systemd-devel" To: Benjamin Tissoires Cc: Len Brown , systemd-devel@lists.freedesktop.org, linux-acpi@vger.kernel.org, "Rafael J . Wysocki" , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, Lv Zheng , Lv Zheng , linux-input@vger.kernel.org List-Id: linux-acpi@vger.kernel.org T24gVGh1LCAwMS4wNi4xNyAyMDo0NiwgQmVuamFtaW4gVGlzc29pcmVzIChiZW5qYW1pbi50aXNz b2lyZXNAcmVkaGF0LmNvbSkgd3JvdGU6Cgo+IEhpLAo+IAo+IFNlbmRpbmcgdGhpcyBhcyBhIFdJ UCBhcyBpdCBzdGlsbCBuZWVkIGEgZmV3IGNoYW5nZXMsIGJ1dCBpdCBtb3N0bHkgd29ya3MgYXMK PiBleHBlY3RlZCAoc3RpbGwgbm90IGZ1bGx5IGNvbXBsaWFudCB5ZXQpLgo+IAo+IFNvIHRoaXMg aXMgYmFzZWQgb24gTGVubmFydCdzIGNvbW1lbnQgaW4gWzFdOiBpZiB0aGUgTElEIHN0YXRlIGlz IG5vdCByZWxpYWJsZSwKPiB0aGUga2VybmVsIHNob3VsZCBub3QgZXhwb3J0IHRoZSBMSUQgc3dp dGNoIGRldmljZSBhcyBsb25nIGFzIHdlIGFyZSBub3Qgc3VyZQo+IGFib3V0IGl0cyBzdGF0ZS4K CkFoIG5pY2UhIEkgKG9idmlvdXNseSkgbGlrZSB0aGlzIGFwcHJvYWNoLgoKPiBOb3RlIHRoYXQg c3lzdGVtZCBjdXJyZW50bHkgZG9lc24ndCBzeW5jIHRoZSBzdGF0ZSB3aGVuIHRoZSBpbnB1dCBu b2RlIGp1c3QKPiBhcHBlYXJzLiBUaGlzIGlzIGEgc3lzdGVtZCBidWcsIGFuZCBpdCBzaG91bGQg bm90IGJlIGhhbmRsZWQgYnkgdGhlIGtlcm5lbAo+IGNvbW11bml0eS4KClVoIGlmIHRoaXMgaXMg Ym9ya2VkLCB3ZSBzaG91bGQgaW5kZWVkIGZpeCB0aGlzIGluIHN5c3RlbWQuIElzIHRoZXJlCmFs cmVhZHkgYSBzeXN0ZW1kIGdpdGh1YiBidWcgYWJvdXQgdGhpcz8gSWYgbm90LCBwbGVhc2UgY3Jl YXRlIG9uZSwKYW5kIHdlJ2xsIGxvb2sgaW50byBpdCEKClRoYW5rcyBmb3Igd29ya2luZyBvbiB0 aGlzLAoKTGVubmFydAoKLS0gCkxlbm5hcnQgUG9ldHRlcmluZywgUmVkIEhhdApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpzeXN0ZW1kLWRldmVsIG1haWxp bmcgbGlzdApzeXN0ZW1kLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3N5c3RlbWQtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751533AbdFGH7A (ORCPT ); Wed, 7 Jun 2017 03:59:00 -0400 Received: from gardel.0pointer.net ([85.214.157.71]:47492 "EHLO gardel.0pointer.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbdFGH67 (ORCPT ); Wed, 7 Jun 2017 03:58:59 -0400 X-Greylist: delayed 608 seconds by postgrey-1.27 at vger.kernel.org; Wed, 07 Jun 2017 03:58:58 EDT Date: Wed, 7 Jun 2017 09:48:48 +0200 From: Lennart Poettering To: Benjamin Tissoires Cc: Lv Zheng , "Rafael J . Wysocki" , "Rafael J . Wysocki" , Len Brown , Lv Zheng , Peter Hutterer , linux-acpi@vger.kernel.org, systemd-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI Message-ID: <20170607074848.GE27006@gardel-login> References: <20170601184632.2980-1-benjamin.tissoires@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170601184632.2980-1-benjamin.tissoires@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 01.06.17 20:46, Benjamin Tissoires (benjamin.tissoires@redhat.com) wrote: > Hi, > > Sending this as a WIP as it still need a few changes, but it mostly works as > expected (still not fully compliant yet). > > So this is based on Lennart's comment in [1]: if the LID state is not reliable, > the kernel should not export the LID switch device as long as we are not sure > about its state. Ah nice! I (obviously) like this approach. > Note that systemd currently doesn't sync the state when the input node just > appears. This is a systemd bug, and it should not be handled by the kernel > community. Uh if this is borked, we should indeed fix this in systemd. Is there already a systemd github bug about this? If not, please create one, and we'll look into it! Thanks for working on this, Lennart -- Lennart Poettering, Red Hat