All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, lvivier@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/2] Make info migrate output consistent
Date: Wed, 7 Jun 2017 19:37:15 +0800	[thread overview]
Message-ID: <20170607113715.GD3847@pxdev.xzpeter.org> (raw)
In-Reply-To: <20170607105810.3003-1-quintela@redhat.com>

On Wed, Jun 07, 2017 at 12:58:08PM +0200, Juan Quintela wrote:
> Hi
> 
> Changes for v2:
> - patches 1 & 2 in previous pull requset
> - create function populate_disk_info (dave suggestion)
> 
> Please, review.
> 
> Thanks, Juan.
> 
> [v1]
> This series make the output of info migrate be printed in a single
> place for the states ACTIVE, CANCELLING and POSTCOPY_ACTIVE.
> 
> The code was duplicated, just use the same code.  Once done that, fix
> the inconsistences that were not needed.

I feel that putting cpu throttling info into populate_ram_info() is
still slightly weird, but hmm it's okay and that's trivial.

Reviewed-by: Peter Xu <peterx@redhat.com>

Thanks,

-- 
Peter Xu

      parent reply	other threads:[~2017-06-07 11:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07 10:58 [Qemu-devel] [PATCH v2 0/2] Make info migrate output consistent Juan Quintela
2017-06-07 10:58 ` [Qemu-devel] [PATCH v2 1/2] ram: Print block stats also in the complete case Juan Quintela
2017-06-12 11:52   ` Dr. David Alan Gilbert
2017-06-12 11:58   ` Laurent Vivier
2017-06-07 10:58 ` [Qemu-devel] [PATCH v2 2/2] ram: Now POSTCOPY_ACTIVE is the same that STATUS_ACTIVE Juan Quintela
2017-06-12 11:57   ` Dr. David Alan Gilbert
2017-06-12 12:01   ` Laurent Vivier
2017-06-07 11:37 ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170607113715.GD3847@pxdev.xzpeter.org \
    --to=peterx@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.