All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Stone <daniel@fooishbar.org>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
	Vidya Srinivas <vidya.srinivas@intel.com>,
	Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS
Date: Wed, 7 Jun 2017 18:33:53 +0300	[thread overview]
Message-ID: <20170607153353.GL12629@intel.com> (raw)
In-Reply-To: <CAPj87rPOMh6MC5FM7rpvTwX69VBZk804dBo3utqoUm045h-Dew@mail.gmail.com>

On Wed, Jun 07, 2017 at 03:24:58PM +0100, Daniel Stone wrote:
> Hi,
> 
> On 7 June 2017 at 13:53, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Wed, Jun 07, 2017 at 12:44:47PM +0100, Daniel Stone wrote:
> >> /*
> >>  * We don't require any
> >>  * CCS block size alignment of the fb under the assumption that the
> >>  * hardware will handle things correctly of only a single pixel
> >>  * gets touched. The compression should be lossless so any garbage
> >>  * pixels as part of the same block shouldn't cause visual artifacts.
> >>  */
> >
> > The alignment requirement is gone in upstream, hence my latest CCS
> > stuff doesn't have the valign/halign stuff anymore.
> 
> Oh sorry, I'd missed the hsub requirement dropping out. That's fine then.
> 
> > Anyways, I'll have to revisit the the offsets[] thing because people
> > didn't like my original linear offset idea, and it doesn't match what
> > userspace already does.
> 
> I'm still really confused about this. Your patches implement a linear
> byte offset. The last time it came up on IRC, all four of myself, Ben,
> Jason, and you, agreed that linear byte offsets were the only thing
> which made sense. The Mesa patchset that's been sent out a couple of
> times and is now in Jason's hands use linear offsets. If everything
> (kernel, Mesa) uses linear offsets, and everyone (the four of us in
> the discussion) wants linear offsets - why revisit?

Mesa doesn't use linear offsets. Or at least it didn't when I last
looked.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-06-07 15:33 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07  4:51 [PATCH 00/11] Adding NV12 support for SKL display Vidya Srinivas
2017-06-07  4:51 ` [PATCH 01/11] drm/i915: Add render decompression support Vidya Srinivas
2017-06-07  4:51 ` [PATCH 02/11] drm/i915: Fix scaling check for 90/270 degree plane rotation Vidya Srinivas
2017-06-07  4:51 ` [PATCH 03/11] drm/i915: Fix SKL+ watermarks for 90/270 rotation Vidya Srinivas
2017-06-07  4:51   ` Vidya Srinivas
2017-06-07  4:51 ` [PATCH 04/11] drm/i915: Fix 90/270 rotated coordinates for FBC Vidya Srinivas
2017-06-07  4:51   ` Vidya Srinivas
2017-06-07  4:51 ` [PATCH 05/11] drm/i915: Implement .get_format_info() hook for CCS Vidya Srinivas
2017-06-07  4:51 ` [PATCH 06/11] drm/i915: Set scaler mode for NV12 Vidya Srinivas
2017-06-07  4:51 ` [PATCH 07/11] drm/i915: Update format_is_yuv() to include NV12 Vidya Srinivas
2017-06-07  4:51 ` [PATCH 08/11] drm/i915: Upscale scaler max scale for NV12 Vidya Srinivas
2017-06-07  4:51 ` [PATCH 09/11] drm/i915: Add NV12 as supported format for primary plane Vidya Srinivas
2017-06-07  4:51 ` [PATCH 10/11] drm/i915: Add NV12 as supported format for sprite plane Vidya Srinivas
2017-06-07  4:51 ` [PATCH 11/11] drm/i915: Add NV12 support to intel_framebuffer_init Vidya Srinivas
2017-06-07  8:01 ` ✗ Fi.CI.BAT: failure for Adding NV12 support for SKL display Patchwork
2017-06-07 10:41 ` [PATCH 0/8] " Vidya Srinivas
2017-06-07 10:41   ` [PATCH 1/8] drm/i915: Add render decompression support Vidya Srinivas
2017-06-07 10:52     ` Daniel Stone
2017-06-07 10:41   ` [PATCH 2/8] drm/i915: Implement .get_format_info() hook for CCS Vidya Srinivas
2017-06-07 10:46     ` Daniel Stone
2017-06-07 10:41   ` [PATCH 3/8] drm/i915: Set scaler mode for NV12 Vidya Srinivas
2017-06-12 13:56     ` Ville Syrjälä
2017-06-15 11:30       ` Srinivas, Vidya
2017-06-07 10:41   ` [PATCH 4/8] drm/i915: Update format_is_yuv() to include NV12 Vidya Srinivas
2017-06-07 10:41   ` [PATCH 5/8] drm/i915: Upscale scaler max scale for NV12 Vidya Srinivas
2017-06-12 14:07     ` Ville Syrjälä
2017-06-07 10:41   ` [PATCH 6/8] drm/i915: Add NV12 as supported format for primary plane Vidya Srinivas
2017-06-12 14:12     ` Ville Syrjälä
2017-06-15 11:30       ` Srinivas, Vidya
2017-06-07 10:41   ` [PATCH 7/8] drm/i915: Add NV12 as supported format for sprite plane Vidya Srinivas
2017-06-12 14:20     ` Ville Syrjälä
2017-06-15 11:30       ` Srinivas, Vidya
2017-06-07 10:41   ` [PATCH 8/8] drm/i915: Add NV12 support to intel_framebuffer_init Vidya Srinivas
2017-06-12 14:25     ` Ville Syrjälä
2017-06-15 11:30       ` Srinivas, Vidya
2017-06-08  9:07   ` [PATCH 0/8] Adding NV12 support for SKL display Jani Nikula
2017-06-07 11:40 ` Vidya Srinivas
2017-06-07 11:40   ` [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS Vidya Srinivas
2017-06-07 11:44     ` Daniel Stone
2017-06-07 12:53       ` Ville Syrjälä
2017-06-07 14:24         ` Daniel Stone
2017-06-07 15:33           ` Ville Syrjälä [this message]
2017-06-07 15:48             ` Daniel Stone
2017-06-07 16:28               ` Ville Syrjälä
2017-06-07 17:14                 ` Daniel Stone
2017-06-07 11:40   ` [PATCH 2/8] drm/i915: Add render decompression support Vidya Srinivas
2017-06-07 11:40   ` [PATCH 3/8] drm/i915: Set scaler mode for NV12 Vidya Srinivas
2017-06-07 11:41   ` [PATCH 4/8] drm/i915: Update format_is_yuv() to include NV12 Vidya Srinivas
2017-06-07 11:41   ` [PATCH 5/8] drm/i915: Upscale scaler max scale for NV12 Vidya Srinivas
2017-06-07 11:41   ` [PATCH 6/8] drm/i915: Add NV12 as supported format for primary plane Vidya Srinivas
2017-06-07 11:41   ` [PATCH 7/8] drm/i915: Add NV12 as supported format for sprite plane Vidya Srinivas
2017-06-07 11:41   ` [PATCH 8/8] drm/i915: Add NV12 support to intel_framebuffer_init Vidya Srinivas
  -- strict thread matches above, loose matches on Subject: below --
2017-06-20  6:10 [PATCH 0/8] Adding NV12 support for SKL display Vidya Srinivas
2017-06-20  6:10 ` [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS Vidya Srinivas
2017-07-10  6:53 [PATCH 0/8] Adding NV12 support for SKL display Vidya Srinivas
2017-07-10  6:53 ` [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS Vidya Srinivas
2017-07-14 23:16   ` Jason Ekstrand
2017-07-11 14:10 [PATCH 0/8] Adding NV12 support for SKL display Vidya Srinivas
2017-07-11 14:10 ` [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS Vidya Srinivas
2017-07-24  4:27 [PATCH 0/8] Adding NV12 support for BXT display Vidya Srinivas
2017-07-24  4:27 ` [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS Vidya Srinivas
2017-07-31  7:04 [PATCH 0/8] Adding NV12 support Vidya Srinivas
2017-07-31  7:04 ` [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS Vidya Srinivas
2017-08-02 21:26   ` Jason Ekstrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170607153353.GL12629@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=ben@bwidawsk.net \
    --cc=daniel@fooishbar.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=vidya.srinivas@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.