All of lore.kernel.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] arm64: avoid KASAN stack overflows
Date: Wed, 7 Jun 2017 17:18:16 +0100	[thread overview]
Message-ID: <20170607161816.GA8330@leverpostej> (raw)
In-Reply-To: <07c30069-84f5-be51-85ab-c3c84eea9463@virtuozzo.com>

On Wed, Jun 07, 2017 at 07:12:30PM +0300, Andrey Ryabinin wrote:
> On 06/07/2017 06:35 PM, Mark Rutland wrote:
> > I recently tried building the kernel with a GCC 7.1.0 toolchain, and
> > encountered a number of new and surprising failures on kernels buitl with
> > KASAN.
> > 
> > It looks like this is due to stack instrumentation, which my prior toolchain
> > didn't support. KASAN's stack instrumentation significantly bloats the stack
> > significantly, leading to stack overflows and subsequent failures as a result
> > of the data corruption they cause.
> 
> This is caused by -fsanitize-address-use-after-scope which is added in gcc 7.
> Arnd reported that sometimes it causes enormously huge stack growth.

Ah. Sorry for the bogus attribution, then.

> Given that we haven't found any single use-after-scope bug so far, I wouldn't object
> removing it completely.  

FWIW, I saw a single use-after-scope splat when testing with syzkaller
(prior to these patches), but that may have been a result of things
going wrong after a stack overflow. Unfortuantely I threw away all of
the results of that run.

I'll see if anything triggers overnight with this patch.

Otherwise, I'm also happy for use-after-scope checks to be disabled.

Thanks,
Mark.

  reply	other threads:[~2017-06-07 16:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07 15:35 [PATCH 0/2] arm64: avoid KASAN stack overflows Mark Rutland
2017-06-07 15:35 ` [PATCH 1/2] arm64: avoid open-coding THREAD_SIZE{,_ORDER} Mark Rutland
2017-06-07 15:35 ` [PATCH 2/2] arm64: use larger stacks for KASAN Mark Rutland
2017-06-07 16:12 ` [PATCH 0/2] arm64: avoid KASAN stack overflows Andrey Ryabinin
2017-06-07 16:18   ` Mark Rutland [this message]
2017-06-07 19:54     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170607161816.GA8330@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.