From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: SeongJae Park <sj38.park@gmail.com>
Cc: peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] perf-script-python.txt: Apply updated trace_unhandled() definition
Date: Wed, 7 Jun 2017 20:27:58 -0300 [thread overview]
Message-ID: <20170607232758.GE6949@kernel.org> (raw)
In-Reply-To: <20170530111827.21732-6-sj38.park@gmail.com>
Em Tue, May 30, 2017 at 08:18:27PM +0900, SeongJae Park escreveu:
> Default definition of trace_unhandled() has updated while
> perf-script-python.txt has not updated. This commit updates the
> document for that.
Thanks, applied to perf/urgent.
- Arnaldo
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> Fixes: c02514850d67b ("perf scripts python: Give field dict to unhandled callback")
> ---
> tools/perf/Documentation/perf-script-python.txt | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-script-python.txt b/tools/perf/Documentation/perf-script-python.txt
> index f723ce41268c..51ec2d20068a 100644
> --- a/tools/perf/Documentation/perf-script-python.txt
> +++ b/tools/perf/Documentation/perf-script-python.txt
> @@ -149,10 +149,8 @@ def raw_syscalls__sys_enter(event_name, context, common_cpu,
> print "id=%d, args=%s\n" % \
> (id, args),
>
> -def trace_unhandled(event_name, context, common_cpu, common_secs, common_nsecs,
> - common_pid, common_comm):
> - print_header(event_name, common_cpu, common_secs, common_nsecs,
> - common_pid, common_comm)
> +def trace_unhandled(event_name, context, event_fields_dict):
> + print ' '.join(['%s=%s'%(k,str(v))for k,v in sorted(event_fields_dict.items())])
>
> def print_header(event_name, cpu, secs, nsecs, pid, comm):
> print "%-20s %5u %05u.%09u %8u %-20s " % \
> @@ -548,8 +546,7 @@ def trace_end():
> of common arguments are passed into it:
>
> ----
> -def trace_unhandled(event_name, context, common_cpu, common_secs,
> - common_nsecs, common_pid, common_comm):
> +def trace_unhandled(event_name, context, event_fields_dict):
> pass
> ----
>
> --
> 2.13.0
next prev parent reply other threads:[~2017-06-07 23:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 11:18 [PATCH 0/5] perf: Fix few nitpicks in perf-script SeongJae Park
2017-05-30 11:18 ` [PATCH 1/5] perf script: Fix outdated comment for perf-trace-python SeongJae Park
2017-06-07 23:19 ` Arnaldo Carvalho de Melo
2017-06-08 22:46 ` [tip:perf/urgent] " tip-bot for SeongJae Park
2017-05-30 11:18 ` [PATCH 2/5] perf-script-python,perl.txt: Fix typos SeongJae Park
2017-06-07 23:19 ` Arnaldo Carvalho de Melo
2017-06-08 22:47 ` [tip:perf/urgent] perf script: Fix documentation errors tip-bot for SeongJae Park
2017-05-30 11:18 ` [PATCH 3/5] perf-script-python.txt: Polish command examples SeongJae Park
2017-06-08 22:49 ` [tip:perf/urgent] perf script python: Remove dups in documentation examples tip-bot for SeongJae Park
2017-05-30 11:18 ` [PATCH 4/5] perf-script-python.txt: Fix wrong code snippets SeongJae Park
2017-06-07 23:35 ` Arnaldo Carvalho de Melo
2017-06-07 23:47 ` SeongJae Park
2017-06-08 22:47 ` [tip:perf/urgent] perf script python: Fix wrong code snippets in documentation tip-bot for SeongJae Park
2017-05-30 11:18 ` [PATCH 5/5] perf-script-python.txt: Apply updated trace_unhandled() definition SeongJae Park
2017-06-07 23:27 ` Arnaldo Carvalho de Melo [this message]
2017-06-08 22:48 ` [tip:perf/urgent] perf script python: Updated trace_unhandled() signature tip-bot for SeongJae Park
2017-06-07 22:42 ` [PATCH 0/5] perf: Fix few nitpicks in perf-script SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607232758.GE6949@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sj38.park@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.