From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 8 Jun 2017 08:58:50 +0200 From: Christoph Hellwig To: Omar Sandoval Cc: Christoph Hellwig , Thomas Gleixner , Jens Axboe , Keith Busch , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/8] blk-mq: create hctx for each present CPU Message-ID: <20170608065850.GA12803@lst.de> References: <20170603140403.27379-1-hch@lst.de> <20170603140403.27379-8-hch@lst.de> <20170607220411.GF7481@vader.DHCP.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170607220411.GF7481@vader.DHCP.thefacebook.com> List-ID: On Wed, Jun 07, 2017 at 03:04:11PM -0700, Omar Sandoval wrote: > On Sat, Jun 03, 2017 at 04:04:02PM +0200, Christoph Hellwig wrote: > > Currently we only create hctx for online CPUs, which can lead to a lot > > of churn due to frequent soft offline / online operations. Instead > > allocate one for each present CPU to avoid this and dramatically simplify > > the code. > > > > Signed-off-by: Christoph Hellwig > > Oh man, this cleanup is great. Did you run blktests on this? block/008 > does a bunch of hotplugging while I/O is running. I haven't run blktests yet, in fact when I did the work blktests didn't exist yet. But thanks for the reminder, I'll run it now. From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Thu, 8 Jun 2017 08:58:50 +0200 Subject: [PATCH 7/8] blk-mq: create hctx for each present CPU In-Reply-To: <20170607220411.GF7481@vader.DHCP.thefacebook.com> References: <20170603140403.27379-1-hch@lst.de> <20170603140403.27379-8-hch@lst.de> <20170607220411.GF7481@vader.DHCP.thefacebook.com> Message-ID: <20170608065850.GA12803@lst.de> On Wed, Jun 07, 2017@03:04:11PM -0700, Omar Sandoval wrote: > On Sat, Jun 03, 2017@04:04:02PM +0200, Christoph Hellwig wrote: > > Currently we only create hctx for online CPUs, which can lead to a lot > > of churn due to frequent soft offline / online operations. Instead > > allocate one for each present CPU to avoid this and dramatically simplify > > the code. > > > > Signed-off-by: Christoph Hellwig > > Oh man, this cleanup is great. Did you run blktests on this? block/008 > does a bunch of hotplugging while I/O is running. I haven't run blktests yet, in fact when I did the work blktests didn't exist yet. But thanks for the reminder, I'll run it now.