From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH 1/2] mempool/dpaa2: fix the return value for
	alloc fail
Date: Thu, 8 Jun 2017 11:53:13 +0200
Message-ID: <20170608115313.342853f3@platinum>
References: <1495532028-9700-1-git-send-email-hemant.agrawal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <stable@dpdk.org>, <shreyansh.jain@nxp.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id 95BC12BBB
 for <dev@dpdk.org>; Thu,  8 Jun 2017 11:53:15 +0200 (CEST)
Received: by mail-wm0-f51.google.com with SMTP id 7so134260076wmo.1
 for <dev@dpdk.org>; Thu, 08 Jun 2017 02:53:15 -0700 (PDT)
In-Reply-To: <1495532028-9700-1-git-send-email-hemant.agrawal@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Hemant,

On Tue, 23 May 2017 15:03:47 +0530, Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
> In case the alloc api is not able to allocate the required
> number of buffer, it can return '0', which will not indicate
> the failure to the calling function.
> This patch fix the return value to indicate the failure.
> 
> Fixes: 5dc43d22b5ad ("mempool/dpaa2: add hardware offloaded mempool")
> CC: stable@dpdk.org
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> index 5a5d6aa..60dd1c0 100644
> --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> @@ -294,7 +294,7 @@
>  			/* Releasing all buffers allocated */
>  			rte_dpaa2_mbuf_release(pool, obj_table, bpid,
>  					   bp_info->meta_data_size, n);
> -			return ret;
> +			return -1;
>  		}
>  		/* assigning mbuf from the acquired objects */
>  		for (i = 0; (i < ret) && bufs[i]; i++) {

Wouldn't it be better to return an errno as done in ring handler
(see common_ring_mp_enqueue()) or in stack handler (see stack_alloc())?

Olivier