From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: i40e: pci probe fails when using one bogus sfp
Date: Thu, 8 Jun 2017 12:13:48 +0200
Message-ID: <20170608121348.5c2f538a@platinum>
References: <20170608112917.22fb51eb@platinum>
 <20170608100154.GA56168@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: helin.zhang@intel.com, jingjing.wu@intel.com, dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id C0DFA2BB9
 for <dev@dpdk.org>; Thu,  8 Jun 2017 12:13:50 +0200 (CEST)
Received: by mail-wm0-f51.google.com with SMTP id m7so36991317wmg.0
 for <dev@dpdk.org>; Thu, 08 Jun 2017 03:13:50 -0700 (PDT)
In-Reply-To: <20170608100154.GA56168@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 8 Jun 2017 11:01:54 +0100, Bruce Richardson <bruce.richardson@intel.com> wrote:
> On Thu, Jun 08, 2017 at 11:29:17AM +0200, Olivier Matz wrote:
> > Hi,
> > 
> > One of our customers encounters an issue with dpdk when there
> > is a bogus SFP on one of the ports. The following message is
> > reported:
> > 
> >   PMD: eth_i40e_dev_init(): Failed to sync phy type: -95 
> > 
> > (note: 95 is EOPNOTSUPP/ENOTSUP)
> > 
> > Unfortunately I cannot reproduce the issue to give more details,
> > but the hypothesis is that it fails in i40e_dev_sync_phy_type().
> > It could be related to that patch:
> > 
> >   http://dpdk.org/browse/dpdk/commit/?id=edfb226f69bf
> > 
> > To me, the expected behavior should be:
> > - pci probe is succesful
> > - the initialization of the port with faulty SFP fails
> > - the initialization of the other ports is succesful
> > 
> > Do you have any comment or idea to fix this issue?
> >   
> And what is the current behaviour you are seeing? The whole PCI probe is
> terminating after the failure on the error port?

Yes, the probe is terminating

> Can that one problem
> port not just be blacklisted, since it's presumably unusable anyway?

This would imply the user (or the manager program) that launches the
application to parse the logs to detect which port fails and update
the configuration accordingly.

I think it would be better to return an error at port initialization,
so that the application can takes its dispositions directly. We could
even imagine that the port could be reenabled later once the SFP is
changed, without restarting the application.


Olivier