Re: [PATCH 14/13] xfs: allow reading of already-locked remote symbolic link

[Brian Foster <bfoster@redhat.com>]

On Fri, Jun 02, 2017 at 03:19:42PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Expose the readlink variant that doesn't take the inode lock so that
> the scrubber can inspect symlink contents.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---

Reviewed-by: Brian Foster <bfoster@redhat.com>

>  fs/xfs/xfs_symlink.c |    6 +++---
>  fs/xfs/xfs_symlink.h |    1 +
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/xfs/xfs_symlink.c b/fs/xfs/xfs_symlink.c
> index f2cb45e..49380485 100644
> --- a/fs/xfs/xfs_symlink.c
> +++ b/fs/xfs/xfs_symlink.c
> @@ -43,8 +43,8 @@
>  #include "xfs_log.h"
>  
>  /* ----- Kernel only functions below ----- */
> -STATIC int
> -xfs_readlink_bmap(
> +int
> +xfs_readlink_bmap_ilocked(
>  	struct xfs_inode	*ip,
>  	char			*link)
>  {
> @@ -153,7 +153,7 @@ xfs_readlink(
>  	}
>  
>  
> -	error = xfs_readlink_bmap(ip, link);
> +	error = xfs_readlink_bmap_ilocked(ip, link);
>  
>   out:
>  	xfs_iunlock(ip, XFS_ILOCK_SHARED);
> diff --git a/fs/xfs/xfs_symlink.h b/fs/xfs/xfs_symlink.h
> index e75245d..aeaee89 100644
> --- a/fs/xfs/xfs_symlink.h
> +++ b/fs/xfs/xfs_symlink.h
> @@ -21,6 +21,7 @@
>  
>  int xfs_symlink(struct xfs_inode *dp, struct xfs_name *link_name,
>  		const char *target_path, umode_t mode, struct xfs_inode **ipp);
> +int xfs_readlink_bmap_ilocked(struct xfs_inode *ip, char *link);
>  int xfs_readlink(struct xfs_inode *ip, char *link);
>  int xfs_inactive_symlink(struct xfs_inode *ip);
>  
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html