From: Kevin Wolf <kwolf@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, lvivier@redhat.com,
Stefan Hajnoczi <stefanha@redhat.com>,
dgilbert@redhat.com, peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/5] Create setup/cleanup methods for migration incoming side
Date: Thu, 8 Jun 2017 15:05:36 +0200 [thread overview]
Message-ID: <20170608130536.GD4427@noname.redhat.com> (raw)
In-Reply-To: <8737bbd6qb.fsf@secure.mitica>
Am 07.06.2017 um 19:53 hat Juan Quintela geschrieben:
> Juan Quintela <quintela@redhat.com> wrote:
> > Hi
>
> Hi Kevin and Stefan, I intended to cc you on this series.
>
> Is this what you were asking for block layer migration?
>
> Do you need anything else?
I didn't manage to apply this to my local git tree, so my review is
based on scanning the emails.
The important part for us is probably where you call the .cleanup_load
callback. As I commented on the patch, I don't see any place in this
series that calls it. We need it before bdrv_invalidate_cache_all() is
called, I think.
Kevin
prev parent reply other threads:[~2017-06-08 13:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 22:15 [Qemu-devel] [PATCH 0/5] Create setup/cleanup methods for migration incoming side Juan Quintela
2017-06-01 22:15 ` [Qemu-devel] [PATCH 1/5] migration: Rename save_live_setup() to save_setup() Juan Quintela
2017-06-01 22:15 ` [Qemu-devel] [PATCH 2/5] migration: Rename cleanup() to save_cleanup() Juan Quintela
2017-06-01 22:15 ` [Qemu-devel] [PATCH 3/5] migration: Create load_setup()/cleanup() methods Juan Quintela
2017-06-08 12:59 ` Kevin Wolf
2017-06-13 9:57 ` Juan Quintela
2017-06-01 22:15 ` [Qemu-devel] [PATCH 4/5] migration: Convert ram to use new load_setup()/load_cleanup() Juan Quintela
2017-06-01 22:15 ` [Qemu-devel] [PATCH 5/5] migration: Make compression_threads use save/load_setup/cleanup() Juan Quintela
2017-06-07 17:53 ` [Qemu-devel] [PATCH 0/5] Create setup/cleanup methods for migration incoming side Juan Quintela
2017-06-08 13:05 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170608130536.GD4427@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.