From: Anatolij Gustschin <agust@denx.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-fpga@vger.kernel.org, Alan Tull <atull@kernel.org>,
Moritz Fischer <moritz.fischer@ettus.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
matthew.gerlach@linux.intel.com, yi1.li@linux.intel.com
Subject: Re: [PATCH v5] fpga manager: Add Altera CvP driver
Date: Thu, 8 Jun 2017 17:00:24 +0200 [thread overview]
Message-ID: <20170608170024.3d2b69b7@crub> (raw)
In-Reply-To: <CAHp75VeWtcUJs2vbdXydn3LWnBakcYNmgswBy50r0GBcNrkkCg@mail.gmail.com>
On Thu, 8 Jun 2017 17:44:19 +0300
Andy Shevchenko andy.shevchenko@gmail.com wrote:
>On Thu, Jun 8, 2017 at 5:15 PM, Anatolij Gustschin <agust@denx.de> wrote:
>> On Thu, 8 Jun 2017 02:38:55 +0300
>> Andy Shevchenko andy.shevchenko@gmail.com wrote:
>>>On Thu, Jun 8, 2017 at 2:09 AM, Anatolij Gustschin <agust@denx.de> wrote:
>>>> On Fri, 2 Jun 2017 20:43:21 +0300
>>>> Andy Shevchenko andy.shevchenko@gmail.com wrote:
>
>>>Besides below comments, please, do
>>>
>>>s/VSEC_/VSE_/g
>>>
>>>for entire file.
>>>
>>>We are following PCI and Thunderbolt pattern for use of Vendor
>>>Specific Extended Capability.
>>
>> I can do it, but I'm just not getting why. The registers are named as VSEC
>> registers in the documentation, why should the code name them differently?
>
>Does your documentation decode VSEC abbreviation?
>What C stands for? Capability?
the CvP user guide talks about Vendor Specific Extended Capability (VSEC).
--
Anatolij
prev parent reply other threads:[~2017-06-08 15:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-14 15:51 [PATCH v5] fpga manager: Add Altera CvP driver Anatolij Gustschin
2017-05-14 19:01 ` kbuild test robot
2017-06-07 23:51 ` Andy Shevchenko
2017-06-02 17:01 ` Anatolij Gustschin
2017-06-02 17:43 ` Andy Shevchenko
2017-06-02 17:44 ` Andy Shevchenko
2017-06-07 23:09 ` Anatolij Gustschin
2017-06-07 23:38 ` Andy Shevchenko
2017-06-08 14:15 ` Anatolij Gustschin
2017-06-08 14:44 ` Andy Shevchenko
2017-06-08 15:00 ` Anatolij Gustschin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170608170024.3d2b69b7@crub \
--to=agust@denx.de \
--cc=andy.shevchenko@gmail.com \
--cc=atull@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=moritz.fischer@ettus.com \
--cc=yi1.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.