Re: [PATCH v2 0/4] Remove PCI and VDEV dependency from eventdev library

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Wed, 7 Jun 2017 11:27:26 +0200
> From: Gaëtan Rivet <gaetan.rivet@6wind.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Cc: dev@dpdk.org, bruce.richardson@intel.com, harry.van.haaren@intel.com,
>  hemant.agrawal@nxp.com, gage.eads@intel.com, nipun.gupta@nxp.com,
>  narender.vangati@intel.com, nikhil.rao@intel.com
> Subject: Re: [dpdk-dev] [PATCH v2 0/4] Remove PCI and VDEV dependency from
>  eventdev library
> User-Agent: Mutt/1.5.23 (2014-03-12)
> 
> Hi Jerin,
> 
> On Wed, Jun 07, 2017 at 02:13:29PM +0530, Jerin Jacob wrote:
> > v3:
> > Removed the bus dependency by spliting lib/librte_eventdev/rte_eventdev_pmd_pci.h
> > and lib/librte_eventdev/rte_eventdev_pmd_vdev.h
> > 
> 
> It works with the PCI bus now, good job.
> Small problem however: to compile drivers/event/sw/sw_evdev.c, two includes were
> missing:
> 
> #include <inttypes.h>
> #include <rte_debug.h>
> 
> I added both to rte_eventdev_pmd_vdev.h to quickly fix this and test the
> compilation otherwise, but maybe this is only necessary for sw_evdev.c.

I tested x86_64-native-linuxapp-gcc + dpdk.org master on following
versions of gcc. I couldn't see the compilation issue. Anyway, I will
send the next version with suggested header file changes.

gcc version 4.9.2 20150212 (Red Hat 4.9.2-6) (GCC) 
gcc version 4.8.3 20140911 (Red Hat 4.8.3-7) (GCC) 
gcc version 7.1.1 20170528 (GCC) 



> 
> Thanks
> 
> > Jerin Jacob (4):
> >   eventdev: remove PCI dependency from generic data structures
> >   eventdev: restructure event PMD release function
> >   eventdev: make PCI probe and remove functions optional
> >   eventdev: make vdev init and uninit functions optional
> > 
> >  drivers/event/octeontx/ssovf_evdev.h        |   2 +-
> >  drivers/event/octeontx/ssovf_worker.h       |   1 +
> >  drivers/event/skeleton/skeleton_eventdev.c  |  33 +++---
> >  drivers/event/skeleton/skeleton_eventdev.h  |   3 +-
> >  drivers/event/sw/sw_evdev.h                 |   2 +-
> >  lib/librte_eventdev/Makefile                |   2 +
> >  lib/librte_eventdev/rte_eventdev.c          | 148 -------------------------
> >  lib/librte_eventdev/rte_eventdev.h          |   2 -
> >  lib/librte_eventdev/rte_eventdev_pmd.h      | 101 +-----------------
> >  lib/librte_eventdev/rte_eventdev_pmd_pci.h  | 160 ++++++++++++++++++++++++++++
> >  lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 133 +++++++++++++++++++++++
> >  11 files changed, 323 insertions(+), 264 deletions(-)
> >  create mode 100644 lib/librte_eventdev/rte_eventdev_pmd_pci.h
> >  create mode 100644 lib/librte_eventdev/rte_eventdev_pmd_vdev.h
> > 
> > -- 
> > 2.13.0
> > 
> 
> -- 
> Gaëtan Rivet
> 6WIND