All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Felix Schnizlein <fschnizlein@suse.com>
Cc: linux-kernel@vger.kernel.org, x86@vger.kernel.org,
	yanmin.zhang@intel.com, trenn@suse.com
Subject: Re: [RFC PATCH 2/3] Implement sysfs based cpuinfo for x86 cpus.
Date: Thu, 8 Jun 2017 20:24:01 +0200	[thread overview]
Message-ID: <20170608182401.GC13995@kroah.com> (raw)
In-Reply-To: <1496940975-9164-3-git-send-email-fschnizlein@suse.com>

On Thu, Jun 08, 2017 at 06:56:14PM +0200, Felix Schnizlein wrote:
> A few entries have been omitted, due to already existing information in
> sysfs:
> 
> - microcode -> /sys/devices/system/cpu/cpu*/microcode/version
> - cache -> /sys/devices/system/cpu/cpu*/cache/index*/size
> - core_id -> /sys/devices/system/cpu/cpu*/topology/core_id
> - siblings -> /sys/devices/system/cpu/cpu*/topology/core_siblings_list
> - pyshical_id -> /sys/devices/system/cpu/cpu*/topology/physical_package_id
> 
> Following attributes have been removed due to obsolete information or
> legacy processors: wp, power management, f00f bug, coma bug, fdiv bug
> 
> Signed-off-by: Thomas Renninger <trenn@suse.com>

Again, no signoff from you?

> ---
>  arch/x86/kernel/Makefile        |   1 +
>  arch/x86/kernel/cpuinfo_sysfs.c | 166 ++++++++++++++++++++++++++++++++++++++++
>  drivers/base/cpuinfo.c          |   4 -
>  3 files changed, 167 insertions(+), 4 deletions(-)
>  create mode 100644 arch/x86/kernel/cpuinfo_sysfs.c
> 

When you add new sysfs entries, you have to also add new
Documentation/ABI/ entries.

thanks,

greg k-h

  parent reply	other threads:[~2017-06-08 18:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1496940975-9164-1-git-send-email-fschnizlein@suse.com>
     [not found] ` <1496940975-9164-2-git-send-email-fschnizlein@suse.com>
2017-06-08 18:22   ` [RFC PATCH 1/3] Add sysfs based cpuinfo structure Greg KH
2017-06-08 18:25   ` Greg KH
     [not found] ` <1496940975-9164-3-git-send-email-fschnizlein@suse.com>
2017-06-08 18:24   ` Greg KH [this message]
2017-06-09 13:28     ` [RFC PATCH 2/3] Implement sysfs based cpuinfo for x86 cpus Thomas Renninger
2017-06-09 15:22       ` Brice Goglin
2017-06-08 18:26   ` Greg KH
     [not found] ` <1496940975-9164-4-git-send-email-fschnizlein@suse.com>
2017-06-08 18:25   ` [RFC PATCH 3/3] Add deprecation warning to cpuinfo proc Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170608182401.GC13995@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=fschnizlein@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trenn@suse.com \
    --cc=x86@vger.kernel.org \
    --cc=yanmin.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.