From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJE8R-0005TS-4l for qemu-devel@nongnu.org; Fri, 09 Jun 2017 03:15:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJE8M-0005rx-AJ for qemu-devel@nongnu.org; Fri, 09 Jun 2017 03:15:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46356) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dJE8M-0005rb-4K for qemu-devel@nongnu.org; Fri, 09 Jun 2017 03:15:02 -0400 Date: Fri, 9 Jun 2017 15:14:55 +0800 From: Peter Xu Message-ID: <20170609071455.GK3628@pxdev.xzpeter.org> References: <1496828798-27548-1-git-send-email-a.perevalov@samsung.com> <1496828798-27548-3-git-send-email-a.perevalov@samsung.com> <20170609041059.GI3628@pxdev.xzpeter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v8 02/11] migration: pass MigrationIncomingState* into migration check functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Perevalov Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, i.maximets@samsung.com On Fri, Jun 09, 2017 at 09:21:38AM +0300, Alexey Perevalov wrote: > On 06/09/2017 07:10 AM, Peter Xu wrote: > >On Wed, Jun 07, 2017 at 12:46:29PM +0300, Alexey Perevalov wrote: > >>That tiny refactoring is necessary to be able to set > >>UFFD_FEATURE_THREAD_ID while requesting features, and then > >>to create downtime context in case when kernel supports it. > >> > >>Signed-off-by: Alexey Perevalov > >>--- > >> migration/migration.c | 3 ++- > >> migration/postcopy-ram.c | 10 +++++----- > >> migration/postcopy-ram.h | 2 +- > >> migration/savevm.c | 2 +- > >> 4 files changed, 9 insertions(+), 8 deletions(-) > >> > >>diff --git a/migration/migration.c b/migration/migration.c > >>index 48c94c9..2a77636 100644 > >>--- a/migration/migration.c > >>+++ b/migration/migration.c > >>@@ -726,6 +726,7 @@ void qmp_migrate_set_capabilities(MigrationCapabilityStatusList *params, > >> Error **errp) > >> { > >> MigrationState *s = migrate_get_current(); > >>+ MigrationIncomingState *mis = migration_incoming_get_current(); > >If this patch is only servicing patch 6, I'd prefer in patch 6 we call > >migration_incoming_get_current() (rather than here), then this patch > >may be dropped?... > I planed this patch as preparation, I used to separate refactoring from main > change, for > easy merging while rebasing. > mis - is necessary here to have the same behaviour as before. Could I ask what's the "same behavior" you mentioned? I thought this patch is only used by patch 6 when creating the blocktime struct (but not really a clean-up), no? -- Peter Xu