All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org,
	Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Sascha Weisenberger <sascha.weisenberger@siemens.com>
Subject: Re: [PATCH v5 03/11] gpio-exar/8250-exar: Fix passing in of parent PCI device
Date: Fri, 9 Jun 2017 10:29:11 +0200	[thread overview]
Message-ID: <20170609082911.GA29675@kroah.com> (raw)
In-Reply-To: <63100617e55d78ab881baaa6baf44e8d74d0e816.1496388533.git.jan.kiszka@siemens.com>

On Fri, Jun 02, 2017 at 09:28:46AM +0200, Jan Kiszka wrote:
> This fixes reloading of the GPIO driver for the same platform device
> instance as created by the exar UART driver: First of all, the driver
> sets drvdata to its own value during probing and does not restore the
> original value on exit. But this won't help anyway as the core clears
> drvdata after the driver left.
> 
> Set the platform device parent instead.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

  parent reply	other threads:[~2017-06-09  8:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-02  7:28 [PATCH v5 00/11] serial/gpio: exar: Fixes and support for IOT2000 Jan Kiszka
2017-06-02  7:28 ` [PATCH v5 01/11] serial: exar: Leave MPIOs as output for Commtech adapters Jan Kiszka
2017-06-09  7:20   ` Linus Walleij
2017-06-09  8:29     ` Greg Kroah-Hartman
2017-06-02  7:28 ` [PATCH v5 02/11] gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards Jan Kiszka
2017-06-02  7:28 ` [PATCH v5 03/11] gpio-exar/8250-exar: Fix passing in of parent PCI device Jan Kiszka
2017-06-09  7:21   ` Linus Walleij
2017-06-09  7:44     ` Jan Kiszka
2017-06-09  8:29   ` Greg Kroah-Hartman [this message]
2017-06-02  7:28 ` [PATCH v5 04/11] gpio: exar: Allocate resources on behalf of the platform device Jan Kiszka
2017-06-02  7:28 ` [PATCH v5 05/11] gpio: exar: Fix iomap request Jan Kiszka
2017-06-02  7:28 ` [PATCH v5 06/11] gpio: exar: Fix reading of directions and values Jan Kiszka
2017-06-02  7:28 ` [PATCH v5 07/11] gpio-exar/8250-exar: Rearrange gpiochip parenthood Jan Kiszka
2017-06-02  7:28 ` [PATCH v5 08/11] serial: exar: Factor out platform hooks Jan Kiszka
2017-06-02  7:28 ` [PATCH v5 09/11] platform: Accept const properties Jan Kiszka
2017-06-02  7:28 ` [PATCH v5 10/11] gpio-exar/8250-exar: Make set of exported GPIOs configurable Jan Kiszka
2017-06-02 10:32   ` Andy Shevchenko
2017-06-02  7:28 ` [PATCH v5 11/11] serial: exar: Add support for IOT2040 device Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170609082911.GA29675@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=gnurou@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sascha.weisenberger@siemens.com \
    --cc=sudip.mukherjee@codethink.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.