From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Greg KH <greg@kroah.com>
Cc: "Bjørn Mork" <bjorn@mork.no>, "Jiri Kosina" <jikos@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Alan Cox" <gnomes@lxorguk.ukuu.org.uk>,
"USB list" <linux-usb@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works
Date: Fri, 9 Jun 2017 11:54:31 +0200 [thread overview]
Message-ID: <20170609095431.GA23491@mail.corp.redhat.com> (raw)
In-Reply-To: <20170609090028.GA30604@kroah.com>
On Jun 09 2017 or thereabouts, Greg KH wrote:
> On Fri, Jun 09, 2017 at 10:52:42AM +0200, Bjørn Mork wrote:
> > Greg KH <greg@kroah.com> writes:
> >
> > > On Fri, Jun 09, 2017 at 10:21:47AM +0200, Jiri Kosina wrote:
> > >> Longer-term, we'd ideally make 'generic' driver special and let it attach
> > >> as a 'last resort driver' if none of the specific driver picked the device
> > >> up during probe. But I don't think our current driver model allows this
> > >> easily ... or is there way I am not seeing?
> > >
> > > Nope, the driver model does not provide a way for this, sorry, it's been
> > > a complaint from the very beginning that we don't really know how to
> > > handle, except to make sure the order of the drivers loaded are the
> > > priority list, and that's not really a solution at all.
> >
> > Add a 'priority' field to struct device_driver and sort the list by this
> > field instead of load order?
>
> We've been over this before :)
I can imagine :)
>
> What happens when a new module is loaded, are you supposed to then
> disconnect a device from an existing driver, recan all of the existing
> drivers, and then bind the "correct" one then?
This particular case might be slightly different than a generic solution
across the tree.
HID devices are supposed to behave properly out of the box and are
expected to be reprobed by design (most input devices have a special boot
mode to be accessed to some extend by the UEFI, and then you have the
shiny proprietary driver that takes over it under windows).
So I don't think it would be an issue to "bind" a generic handling of a
device, and somehow retrigger a probe when the actual hid-specific
driver comes in (and we know we are using the default, non ideal,
handling).
The current driver model won't allow this by design, but I'll try to work
around this if it is possible in the hid tree as a specific case.
Cheers,
Benjamin
>
> sorry,
>
> greg k-h
next prev parent reply other threads:[~2017-06-09 9:54 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 15:27 Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works Alan Cox
2017-06-07 16:07 ` Greg KH
2017-06-07 18:21 ` Alan Cox
[not found] ` <20170607192158.1eb9db3a-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
2017-06-07 20:45 ` Alan Stern
2017-06-08 19:39 ` Alan Cox
[not found] ` <20170608203904.73abb5e1-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
2017-06-08 19:49 ` Alan Stern
2017-06-08 20:17 ` Linus Torvalds
2017-06-09 7:35 ` Hans de Goede
2017-06-09 8:21 ` Jiri Kosina
2017-06-09 8:27 ` Greg KH
[not found] ` <20170609082703.GA29271-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-06-09 8:52 ` Bjørn Mork
2017-06-09 8:57 ` Hans de Goede
2017-06-09 9:00 ` Greg KH
2017-06-09 9:54 ` Benjamin Tissoires [this message]
2017-06-09 10:41 ` Bjørn Mork
[not found] ` <87y3t1h290.fsf-3F4PFWf5pNjpjLOzFPqGjWGXanvQGlWp@public.gmane.org>
2017-06-09 10:54 ` Bjørn Mork
[not found] ` <alpine.LSU.2.20.1706090959150.30709-YHPUNQjx9ReKbouaWp301Q@public.gmane.org>
2017-06-09 11:25 ` [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works) Jiri Kosina
2017-06-09 11:29 ` Hans de Goede
2017-06-09 13:00 ` Benjamin Tissoires
2017-06-09 13:15 ` Hans de Goede
2017-06-09 14:29 ` Hans de Goede
[not found] ` <05b492e4-5b76-5665-18a8-4ceddb15d220-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-06-13 10:35 ` Jiri Kosina
[not found] ` <alpine.LSU.2.20.1706131134380.30709-YHPUNQjx9ReKbouaWp301Q@public.gmane.org>
2017-06-13 13:41 ` Benjamin Tissoires
[not found] ` <20170613134128.GE29589-/m+UfqrgI5QNLKR9yMNcA1aTQe2KTcn/@public.gmane.org>
2017-06-13 14:02 ` Benjamin Tissoires
2017-06-13 14:54 ` Jiri Kosina
2017-06-15 10:46 ` Jiri Kosina
2017-06-15 14:45 ` Benjamin Tissoires
2017-06-14 8:24 ` [PATCH 0/3] Proposal for making hid_have_special_driver obsolete Benjamin Tissoires
[not found] ` <20170614082441.5270-1-benjamin.tissoires-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-06-14 8:24 ` [PATCH 1/3] HID: core: move the dynamic quirks handling in core Benjamin Tissoires
2017-06-14 9:58 ` Andy Shevchenko
2017-06-14 12:41 ` Benjamin Tissoires
[not found] ` <CAHp75VfGV2n8wXgL9i+45Sw7JmmKgiwpARi=+V5qeRZuzc+BtQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-14 12:44 ` [PATCH Resent " Benjamin Tissoires
2017-06-14 8:24 ` [PATCH 2/3] HID: quirks: move the list of special devices into a quirk Benjamin Tissoires
2017-06-14 8:24 ` [PATCH 3/3] HID: core: remove the absolute need of hid_have_special_driver[] Benjamin Tissoires
2017-06-14 10:07 ` [PATCH 0/3] Proposal for making hid_have_special_driver obsolete Bastien Nocera
2017-06-14 12:29 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609095431.GA23491@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=bjorn@mork.no \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.