From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 04/17] drm/i915/cnl: Allow dynamic cdclk
	changes on CNL
Date: Fri, 9 Jun 2017 17:34:55 +0300
Message-ID: <20170609143455.GX12629@intel.com>
References: <1496959406-6031-1-git-send-email-rodrigo.vivi@intel.com>
 <1496959406-6031-4-git-send-email-rodrigo.vivi@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 8AE5B6E662
 for <intel-gfx@lists.freedesktop.org>; Fri,  9 Jun 2017 14:34:59 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <1496959406-6031-4-git-send-email-rodrigo.vivi@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Sanyog Kale <sanyog.r.kale@intel.com>, intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBKdW4gMDgsIDIwMTcgYXQgMDM6MDM6MTNQTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy
b3RlOgo+IEFsbCB0aGUgbG93IGxldmVsIGNkY2xrIGJpdHMgYXJlIHByZXNlbnQsIHNvIGxldCdz
IGFkZCB0aGUgcmVxdWlyZWQKPiBob29rcyB0byByZWNvbmZpZ3VyZSBjZGNsayBvbiB0aGUgZmx5
Lgo+IAo+IHYyOiBSZWJhc2UgZHVlIHRvIGNubF9zYW5pdGl6ZV9jZGNsaygpCj4gdjM6IFJlYmFz
ZWQgYnkgUm9kcmlnbyBvbiB0b3Agb2YgVmlsbGUncyBjZGNsayByZXdvcmsuCj4gdjQ6IFJlYmFz
ZSBtb3ZpbmcgY25sX2NhbGNfY2RjbGsgdXAgdG8gZm9sbG93IHNhbWUgb3JkZXIKPiAgICAgYXMg
cHJldmlvdXMgcGxhdGZvcm1zLgo+IHYyOiBTcXVhc2ggZHJtL2k5MTUvY25sOiBBZGp1c3QgbWlu
IHBpeGVsIHJhdGUuIHRvIGFkZHJlc3MKPiAgICAgdGhlIGN1cnJlbnQgbGltaXRhdGlvbiB3aGVy
ZSBDRENMSyBjYW5ub3QgYmUgc2V0IHRvIDE2OE1Iego+ICAgICBpZiBhdWRpbyBpcyB1c2VkIHdp
dGggOTZNSHouIChJbXJlKQo+IAo+IENjOiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+
Cj4gQ2M6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29t
Pgo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5p
bnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50
ZWwuY29tPgo+IAo+IENhbm5vbmxha2UgYWxzbyBuZWVkcyB0byBhZGp1c3QgdGhlIG1pbmltYWwg
cGl4ZWwgcmF0ZQo+IGFzIGdlbjkgcGxhdGZvcm1zLiBTcGVjaWFsbHkgZm9yIHRoZSBBemFsaWEg
YXVkaW8gY2FzZS4KPiAKPiBDYzogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5k
aXlhbkBpbnRlbC5jb20+Cj4gQ2M6IFNhbnlvZyBLYWxlIDxzYW55b2cuci5rYWxlQGludGVsLmNv
bT4KPiBTaWduZWQtb2ZmLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+
Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMgfCA1NiArKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKystLQo+ICAxIGZpbGUgY2hhbmdlZCwgNTMgaW5z
ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfY2RjbGsuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xr
LmMKPiBpbmRleCAzNWExNDMyLi4xZDdjZmM1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2NkY2xrLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9j
ZGNsay5jCj4gQEAgLTE0MDAsNiArMTQwMCwxNiBAQCB2b2lkIGJ4dF91bmluaXRfY2RjbGsoc3Ry
dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJYnh0X3NldF9jZGNsayhkZXZfcHJp
diwgJmNkY2xrX3N0YXRlKTsKPiAgfQo+ICAKPiArc3RhdGljIGludCBjbmxfY2FsY19jZGNsayhp
bnQgbWF4X3BpeGNsaykKPiArewo+ICsJaWYgKG1heF9waXhjbGsgPiAzMzYwMDApCj4gKwkJcmV0
dXJuIDUyODAwMDsKPiArCWVsc2UgaWYgKG1heF9waXhjbGsgPiAxNjgwMDApCj4gKwkJcmV0dXJu
IDMzNjAwMDsKPiArCWVsc2UKPiArCQlyZXR1cm4gMTY4MDAwOwo+ICt9Cj4gKwo+ICBzdGF0aWMg
dm9pZCBjbmxfY2RjbGtfcGxsX3VwZGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By
aXYsCj4gIAkJCQkgc3RydWN0IGludGVsX2NkY2xrX3N0YXRlICpjZGNsa19zdGF0ZSkKPiAgewo+
IEBAIC0xNjQxLDcgKzE2NTEsNyBAQCB2b2lkIGNubF9pbml0X2NkY2xrKHN0cnVjdCBkcm1faTkx
NV9wcml2YXRlICpkZXZfcHJpdikKPiAgCj4gIAljZGNsa19zdGF0ZSA9IGRldl9wcml2LT5jZGNs
ay5odzsKPiAgCj4gLQljZGNsa19zdGF0ZS5jZGNsayA9IDE2ODAwMDsKPiArCWNkY2xrX3N0YXRl
LmNkY2xrID0gY25sX2NhbGNfY2RjbGsoMCk7Cj4gIAljZGNsa19zdGF0ZS52Y28gPSBjbmxfY2Rj
bGtfcGxsX3ZjbyhkZXZfcHJpdiwgY2RjbGtfc3RhdGUuY2RjbGspOwo+ICAKPiAgCWNubF9zZXRf
Y2RjbGsoZGV2X3ByaXYsICZjZGNsa19zdGF0ZSk7Cj4gQEAgLTE3NjgsNyArMTc3OCw3IEBAIHN0
YXRpYyBpbnQgaW50ZWxfbWF4X3BpeGVsX3JhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0
YXRlKQo+ICAKPiAgCQlwaXhlbF9yYXRlID0gY3J0Y19zdGF0ZS0+cGl4ZWxfcmF0ZTsKPiAgCj4g
LQkJaWYgKElTX0JST0FEV0VMTChkZXZfcHJpdikgfHwgSVNfR0VOOShkZXZfcHJpdikpCj4gKwkJ
aWYgKElTX0JST0FEV0VMTChkZXZfcHJpdikgfHwgSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KQo+
ICAJCQlwaXhlbF9yYXRlID0KPiAgCQkJCWJkd19hZGp1c3RfbWluX3BpcGVfcGl4ZWxfcmF0ZShj
cnRjX3N0YXRlLAo+ICAJCQkJCQkJICAgICAgIHBpeGVsX3JhdGUpOwoKSSB0aGluayB5b3UgbWln
aHQgYWxzbyBoYXZlIHRvIGFkanVzdCBzb21lIG9mIHRoZSBjbG9jayBsaW1pdHMKd2l0aGluIGJk
d19hZGp1c3RfbWluX3BpcGVfcGl4ZWxfcmF0ZSgpLgoKPiBAQCAtMTkyOSw2ICsxOTM5LDQwIEBA
IHN0YXRpYyBpbnQgYnh0X21vZGVzZXRfY2FsY19jZGNsayhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0
ZSAqc3RhdGUpCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiArc3RhdGljIGludCBjbmxfbW9kZXNl
dF9jYWxjX2NkY2xrKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiArewo+ICsJc3Ry
dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShzdGF0ZS0+ZGV2KTsKPiAr
CXN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKmludGVsX3N0YXRlID0KPiArCQl0b19pbnRlbF9h
dG9taWNfc3RhdGUoc3RhdGUpOwo+ICsJaW50IG1heF9waXhjbGsgPSBpbnRlbF9tYXhfcGl4ZWxf
cmF0ZShzdGF0ZSk7Cj4gKwlpbnQgY2RjbGssIHZjbzsKPiArCj4gKwljZGNsayA9IGNubF9jYWxj
X2NkY2xrKG1heF9waXhjbGspOwo+ICsJdmNvID0gY25sX2NkY2xrX3BsbF92Y28oZGV2X3ByaXYs
IGNkY2xrKTsKPiArCj4gKwlpZiAoY2RjbGsgPiBkZXZfcHJpdi0+bWF4X2NkY2xrX2ZyZXEpIHsK
PiArCQlEUk1fREVCVUdfS01TKCJyZXF1ZXN0ZWQgY2RjbGsgKCVkIGtIeikgZXhjZWVkcyBtYXgg
KCVkIGtIeilcbiIsCj4gKwkJCSAgICAgIGNkY2xrLCBkZXZfcHJpdi0+bWF4X2NkY2xrX2ZyZXEp
Owo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJfQo+ICsKPiArCWludGVsX3N0YXRlLT5jZGNsay5s
b2dpY2FsLnZjbyA9IHZjbzsKPiArCWludGVsX3N0YXRlLT5jZGNsay5sb2dpY2FsLmNkY2xrID0g
Y2RjbGs7Cj4gKwo+ICsJaWYgKCFpbnRlbF9zdGF0ZS0+YWN0aXZlX2NydGNzKSB7Cj4gKwkJY2Rj
bGsgPSBjbmxfY2FsY19jZGNsaygwKTsKPiArCQl2Y28gPSBjbmxfY2RjbGtfcGxsX3ZjbyhkZXZf
cHJpdiwgY2RjbGspOwo+ICsKPiArCQlpbnRlbF9zdGF0ZS0+Y2RjbGsuYWN0dWFsLnZjbyA9IHZj
bzsKPiArCQlpbnRlbF9zdGF0ZS0+Y2RjbGsuYWN0dWFsLmNkY2xrID0gY2RjbGs7Cj4gKwl9IGVs
c2Ugewo+ICsJCWludGVsX3N0YXRlLT5jZGNsay5hY3R1YWwgPQo+ICsJCQlpbnRlbF9zdGF0ZS0+
Y2RjbGsubG9naWNhbDsKPiArCX0KPiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiAgc3RhdGlj
IGludCBpbnRlbF9jb21wdXRlX21heF9kb3RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2KQo+ICB7Cj4gIAlpbnQgbWF4X2NkY2xrX2ZyZXEgPSBkZXZfcHJpdi0+bWF4X2NkY2xr
X2ZyZXE7Cj4gQEAgLTE5NjAsNyArMjAwNCw5IEBAIHN0YXRpYyBpbnQgaW50ZWxfY29tcHV0ZV9t
YXhfZG90Y2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgICovCj4gIHZv
aWQgaW50ZWxfdXBkYXRlX21heF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By
aXYpCj4gIHsKPiAtCWlmIChJU19HRU45X0JDKGRldl9wcml2KSkgewo+ICsJaWYgKElTX0NBTk5P
TkxBS0UoZGV2X3ByaXYpKSB7Cj4gKwkJZGV2X3ByaXYtPm1heF9jZGNsa19mcmVxID0gNTI4MDAw
Owo+ICsJfSBlbHNlIGlmIChJU19HRU45X0JDKGRldl9wcml2KSkgewo+ICAJCXUzMiBsaW1pdCA9
IEk5MTVfUkVBRChTS0xfREZTTSkgJiBTS0xfREZTTV9DRENMS19MSU1JVF9NQVNLOwo+ICAJCWlu
dCBtYXhfY2RjbGssIHZjbzsKPiAgCj4gQEAgLTIxNTcsNiArMjIwMywxMCBAQCB2b2lkIGludGVs
X2luaXRfY2RjbGtfaG9va3Moc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJ
CWRldl9wcml2LT5kaXNwbGF5LnNldF9jZGNsayA9IHNrbF9zZXRfY2RjbGs7Cj4gIAkJZGV2X3By
aXYtPmRpc3BsYXkubW9kZXNldF9jYWxjX2NkY2xrID0KPiAgCQkJc2tsX21vZGVzZXRfY2FsY19j
ZGNsazsKPiArCX0gZWxzZSBpZiAoSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikpIHsKPiArCQlkZXZf
cHJpdi0+ZGlzcGxheS5zZXRfY2RjbGsgPSBjbmxfc2V0X2NkY2xrOwo+ICsJCWRldl9wcml2LT5k
aXNwbGF5Lm1vZGVzZXRfY2FsY19jZGNsayA9Cj4gKwkJCWNubF9tb2Rlc2V0X2NhbGNfY2RjbGs7
Cj4gIAl9Cj4gIAo+ICAJaWYgKElTX0NBTk5PTkxBS0UoZGV2X3ByaXYpKQo+IC0tIAo+IDEuOS4x
CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs
aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h
bi9saXN0aW5mby9pbnRlbC1nZngK