From: Andrew Lunn <andrew@lunn.ch>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net,
thibaut.collet@6wind.com, linville@tuxdriver.com
Subject: Re: [PATCH net-next] bonding: warn user when 802.3ad speed is unknown
Date: Fri, 9 Jun 2017 16:59:32 +0200 [thread overview]
Message-ID: <20170609145932.GG20756@lunn.ch> (raw)
In-Reply-To: <fcca67e0-a170-6dd7-dcbb-7a0ecc0453d5@6wind.com>
> > I just wonder if this should be rate limited?
> So using net_warn_ratelimited()?
>
> Displaying this message continuously in the log, even at a low rate, seems not
> the best things to do. The first time seems enough, but it would require more
> code for that. Is it not over-engineering?
Maybe look at the _once functions, dev_warn_once, printk_once.
> The ideal solution would be a BUILD_BUG_ON(), but I don't see how to make that.
Me neither.
Andrew
next prev parent reply other threads:[~2017-06-09 14:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 9:18 [PATCH net 1/3] bonding: fix 802.3ad support for 5G and 50G speeds Nicolas Dichtel
2017-06-08 9:18 ` [PATCH net 2/3] bonding: fix 802.3ad support for 14G speed Nicolas Dichtel
2017-06-08 12:55 ` Andy Gospodarek
2017-06-08 16:48 ` Andrew Lunn
2017-06-09 13:34 ` [PATCH net-next] bonding: warn user when 802.3ad speed is unknown Nicolas Dichtel
2017-06-09 14:23 ` Andrew Lunn
2017-06-09 14:39 ` Nicolas Dichtel
2017-06-09 14:51 ` Andy Gospodarek
2017-06-09 14:59 ` Andrew Lunn [this message]
2017-06-09 15:58 ` [PATCH net-next v2] " Nicolas Dichtel
2017-06-10 20:07 ` David Miller
2017-06-10 20:01 ` [PATCH net-next] " David Miller
2017-06-08 20:06 ` [PATCH net 2/3] bonding: fix 802.3ad support for 14G speed David Miller
2017-06-09 0:05 ` Joe Perches
2017-06-09 13:45 ` [PATCH net] net: phy: add missing SPEED_14000 Nicolas Dichtel
2017-06-08 9:18 ` [PATCH net 3/3] ethtool.h: remind to update 802.3ad when adding new speeds Nicolas Dichtel
2017-06-08 12:56 ` Andy Gospodarek
2017-06-08 20:06 ` David Miller
2017-06-08 12:55 ` [PATCH net 1/3] bonding: fix 802.3ad support for 5G and 50G speeds Andy Gospodarek
2017-06-08 20:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609145932.GG20756@lunn.ch \
--to=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=j.vosburgh@gmail.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=thibaut.collet@6wind.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.