From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Rob Herring <robh@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Andi Shyti <andi.shyti@samsung.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: stmfts - mark all PM functions as __maybe_unused
Date: Fri, 9 Jun 2017 09:58:32 -0700 [thread overview]
Message-ID: <20170609165832.GA3539@dtor-ws> (raw)
In-Reply-To: <20170609103328.3130682-1-arnd@arndb.de>
On Fri, Jun 09, 2017 at 12:32:48PM +0200, Arnd Bergmann wrote:
> We get a harmless warning when CONFIG_RUNTIME_PM is disabled:
>
> drivers/input/touchscreen/stmfts.c:760:12: error: 'stmfts_runtime_resume' defined but not used [-Werror=unused-function]
> static int stmfts_runtime_resume(struct device *dev)
> drivers/input/touchscreen/stmfts.c:748:12: error: 'stmfts_runtime_suspend' defined but not used [-Werror=unused-function]
> static int stmfts_runtime_suspend(struct device *dev)
>
> The regular PM functions are already marked as __maybe_unused, so let's
> do the same for the runtime-PM as well.
>
> Fixes: 78bcac7b2ae1 ("Input: add support for the STMicroelectronics FingerTip touchscreen")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thank you.
> ---
> drivers/input/touchscreen/stmfts.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
> index 802d0e82d034..157fdb4bb2e8 100644
> --- a/drivers/input/touchscreen/stmfts.c
> +++ b/drivers/input/touchscreen/stmfts.c
> @@ -745,7 +745,7 @@ static int stmfts_remove(struct i2c_client *client)
> return 0;
> }
>
> -static int stmfts_runtime_suspend(struct device *dev)
> +static int __maybe_unused stmfts_runtime_suspend(struct device *dev)
> {
> struct stmfts_data *sdata = dev_get_drvdata(dev);
> int ret;
> @@ -757,7 +757,7 @@ static int stmfts_runtime_suspend(struct device *dev)
> return ret;
> }
>
> -static int stmfts_runtime_resume(struct device *dev)
> +static int __maybe_unused stmfts_runtime_resume(struct device *dev)
> {
> struct stmfts_data *sdata = dev_get_drvdata(dev);
> int ret;
> --
> 2.9.0
>
--
Dmitry
prev parent reply other threads:[~2017-06-09 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 10:32 [PATCH] Input: stmfts - mark all PM functions as __maybe_unused Arnd Bergmann
2017-06-09 16:58 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609165832.GA3539@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andi.shyti@samsung.com \
--cc=arnd@arndb.de \
--cc=javier@osg.samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.