From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 04/17] drm/i915/cnl: Allow dynamic cdclk changes on CNL Date: Fri, 9 Jun 2017 22:32:54 +0300 Message-ID: <20170609193254.GY12629@intel.com> References: <1496959406-6031-1-git-send-email-rodrigo.vivi@intel.com> <1496959406-6031-4-git-send-email-rodrigo.vivi@intel.com> <20170609143455.GX12629@intel.com> <20170609190209.GA23660@ideak-desk.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 87A776E6DB for ; Fri, 9 Jun 2017 19:32:58 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170609190209.GA23660@ideak-desk.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: Sanyog Kale , intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKdW4gMDksIDIwMTcgYXQgMTA6MDI6MDlQTSArMDMwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IE9uIEZyaSwgSnVuIDA5LCAyMDE3IGF0IDA1OjM0OjU1UE0gKzAzMDAsIFZpbGxlIFN5cmrD pGzDpCB3cm90ZToKPiA+IE9uIFRodSwgSnVuIDA4LCAyMDE3IGF0IDAzOjAzOjEzUE0gLTA3MDAs IFJvZHJpZ28gVml2aSB3cm90ZToKPiA+ID4gQWxsIHRoZSBsb3cgbGV2ZWwgY2RjbGsgYml0cyBh cmUgcHJlc2VudCwgc28gbGV0J3MgYWRkIHRoZSByZXF1aXJlZAo+ID4gPiBob29rcyB0byByZWNv bmZpZ3VyZSBjZGNsayBvbiB0aGUgZmx5Lgo+ID4gPiAKPiA+ID4gdjI6IFJlYmFzZSBkdWUgdG8g Y25sX3Nhbml0aXplX2NkY2xrKCkKPiA+ID4gdjM6IFJlYmFzZWQgYnkgUm9kcmlnbyBvbiB0b3Ag b2YgVmlsbGUncyBjZGNsayByZXdvcmsuCj4gPiA+IHY0OiBSZWJhc2UgbW92aW5nIGNubF9jYWxj X2NkY2xrIHVwIHRvIGZvbGxvdyBzYW1lIG9yZGVyCj4gPiA+ICAgICBhcyBwcmV2aW91cyBwbGF0 Zm9ybXMuCj4gPiA+IHYyOiBTcXVhc2ggZHJtL2k5MTUvY25sOiBBZGp1c3QgbWluIHBpeGVsIHJh dGUuIHRvIGFkZHJlc3MKPiA+ID4gICAgIHRoZSBjdXJyZW50IGxpbWl0YXRpb24gd2hlcmUgQ0RD TEsgY2Fubm90IGJlIHNldCB0byAxNjhNSHoKPiA+ID4gICAgIGlmIGF1ZGlvIGlzIHVzZWQgd2l0 aCA5Nk1Iei4gKEltcmUpCj4gPiA+IAo+ID4gPiBDYzogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50 ZWwuY29tPgo+ID4gPiBDYzogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlh bkBpbnRlbC5jb20+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUu c3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IFJvZHJpZ28gVml2 aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+ID4gCj4gPiA+IENhbm5vbmxha2UgYWxzbyBu ZWVkcyB0byBhZGp1c3QgdGhlIG1pbmltYWwgcGl4ZWwgcmF0ZQo+ID4gPiBhcyBnZW45IHBsYXRm b3Jtcy4gU3BlY2lhbGx5IGZvciB0aGUgQXphbGlhIGF1ZGlvIGNhc2UuCj4gPiA+IAo+ID4gPiBD YzogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4g PiA+IENjOiBTYW55b2cgS2FsZSA8c2FueW9nLnIua2FsZUBpbnRlbC5jb20+Cj4gPiA+IFNpZ25l ZC1vZmYtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+ID4gLS0t Cj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jIHwgNTYgKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrLS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA1MyBp bnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9jZGNsay5jCj4gPiA+IGluZGV4IDM1YTE0MzIuLjFkN2NmYzUgMTAwNjQ0Cj4gPiA+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMKPiA+ID4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfY2RjbGsuYwo+ID4gPiBAQCAtMTQwMCw2ICsxNDAwLDE2IEBA IHZvaWQgYnh0X3VuaW5pdF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4gPiA+ICAJYnh0X3NldF9jZGNsayhkZXZfcHJpdiwgJmNkY2xrX3N0YXRlKTsKPiA+ID4gIH0K PiA+ID4gIAo+ID4gPiArc3RhdGljIGludCBjbmxfY2FsY19jZGNsayhpbnQgbWF4X3BpeGNsaykK PiA+ID4gK3sKPiA+ID4gKwlpZiAobWF4X3BpeGNsayA+IDMzNjAwMCkKPiA+ID4gKwkJcmV0dXJu IDUyODAwMDsKPiA+ID4gKwllbHNlIGlmIChtYXhfcGl4Y2xrID4gMTY4MDAwKQo+ID4gPiArCQly ZXR1cm4gMzM2MDAwOwo+ID4gPiArCWVsc2UKPiA+ID4gKwkJcmV0dXJuIDE2ODAwMDsKPiA+ID4g K30KPiA+ID4gKwo+ID4gPiAgc3RhdGljIHZvaWQgY25sX2NkY2xrX3BsbF91cGRhdGUoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gPiAgCQkJCSBzdHJ1Y3QgaW50ZWxfY2Rj bGtfc3RhdGUgKmNkY2xrX3N0YXRlKQo+ID4gPiAgewo+ID4gPiBAQCAtMTY0MSw3ICsxNjUxLDcg QEAgdm9pZCBjbmxfaW5pdF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4gPiA+ICAKPiA+ID4gIAljZGNsa19zdGF0ZSA9IGRldl9wcml2LT5jZGNsay5odzsKPiA+ID4g IAo+ID4gPiAtCWNkY2xrX3N0YXRlLmNkY2xrID0gMTY4MDAwOwo+ID4gPiArCWNkY2xrX3N0YXRl LmNkY2xrID0gY25sX2NhbGNfY2RjbGsoMCk7Cj4gPiA+ICAJY2RjbGtfc3RhdGUudmNvID0gY25s X2NkY2xrX3BsbF92Y28oZGV2X3ByaXYsIGNkY2xrX3N0YXRlLmNkY2xrKTsKPiA+ID4gIAo+ID4g PiAgCWNubF9zZXRfY2RjbGsoZGV2X3ByaXYsICZjZGNsa19zdGF0ZSk7Cj4gPiA+IEBAIC0xNzY4 LDcgKzE3NzgsNyBAQCBzdGF0aWMgaW50IGludGVsX21heF9waXhlbF9yYXRlKHN0cnVjdCBkcm1f YXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+ID4gIAo+ID4gPiAgCQlwaXhlbF9yYXRlID0gY3J0Y19z dGF0ZS0+cGl4ZWxfcmF0ZTsKPiA+ID4gIAo+ID4gPiAtCQlpZiAoSVNfQlJPQURXRUxMKGRldl9w cml2KSB8fCBJU19HRU45KGRldl9wcml2KSkKPiA+ID4gKwkJaWYgKElTX0JST0FEV0VMTChkZXZf cHJpdikgfHwgSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KQo+ID4gPiAgCQkJcGl4ZWxfcmF0ZSA9 Cj4gPiA+ICAJCQkJYmR3X2FkanVzdF9taW5fcGlwZV9waXhlbF9yYXRlKGNydGNfc3RhdGUsCj4g PiA+ICAJCQkJCQkJICAgICAgIHBpeGVsX3JhdGUpOwo+ID4gCj4gPiBJIHRoaW5rIHlvdSBtaWdo dCBhbHNvIGhhdmUgdG8gYWRqdXN0IHNvbWUgb2YgdGhlIGNsb2NrIGxpbWl0cwo+ID4gd2l0aGlu IGJkd19hZGp1c3RfbWluX3BpcGVfcGl4ZWxfcmF0ZSgpLgo+IAo+IFllcywgd2UgbWlzc2VkIHRo aXMuIFRoZSBEUC9IQlIyLzQtbGFuZXMvYXVkaW8gd29ya2Fyb3VuZCBvbiBDTkwgaXMgdGhlCj4g c2FtZSBhcyBvbiBHTEsuIFNvIGluIGJkd19hZGp1c3RfbWluX3BpcGVfcGl4ZWxfcmF0ZSgpIHdl IGNvdWxkIHVzZSB0aGUKPiBzYW1lIGxpbWl0cyBhcyBvbiBHTEssIGV4Y2VwdCBJIGRvbid0IHVu ZGVyc3RhbmQgdGhlIDJ4IG11bHRpcGxpZXIgdGhlcmUKPiBpbgo+IAo+IHBpeGVsX3JhdGUgPSBt YXgoMiAqIDMxNjgwMCwgcGl4ZWxfcmF0ZSk7Cj4gCj4gYW5kCj4gCj4gcGl4ZWxfcmF0ZSA9IG1h eCgyICogMiAqIDk2MDAwLCBwaXhlbF9yYXRlKTsKPiAKPiBUaGlzIHBpeGVsX3JhdGUgdmFsdWUg d2lsbCBiZSBjb21wYXJlZCBhZ2FpbnN0IENEQ0xLIGxpbWl0IHZhbHVlcyBpbgo+IGdsa19jYWxj X2NkY2xrKCkKCkl0J3MgZ29pbmcgdG8gY29tcGFyZSBhZ2FpbnN0IDIqY2RjbGsuIEJ1dCB0aGF0 IGRvZXNuJ3QgbWVhbiBpdCBpc24ndApleHRyZW1lbHkgY29uZnVzaW5nLiBUbyBtYWtlIGl0IG1v cmUgc2FuZSwgSSB0aGluayB3ZSBzaG91bGQgcHJvYmFibHkKcy9taW5fcGl4Y2xrL21pbl9jZGNs ay8gYW5kIGFjdHVhbGx5IHRyYWNrIHRoZSAibWluIGFjY2VwdGFibGUgY2RjbGsiCnJhdGhlciB0 aGFuICJ0aGUgcGl4ZWwgcmF0ZSBjb3JyZXNwb25kaW5nIHRvIHRoZSBtaW4gYWNjZXB0YWJsZSBj ZGNsayIuCgo+IG5vdCBDRDJYQ0xLIGxpbWl0IHZhbHVlcy4gUmVtb3ZpbmcgdGhlIDJ4IG11bHRp cGxpZXIKPiBmcm9tIHRoZSBhYm92ZSBwaXhlbF9yYXRlIHZhbHVlcyB3b3VsZG4ndCBjaGFuZ2Ug YW55dGhpbmcgb24gR0xLIEFGQUlDUwo+IGFuZCBpdCB3b3VsZCBhbGxvdyB1cyB0byB1c2UgdGhl IHNhbWUgY29kZSB0byBjYWxjdWxhdGUgdGhlc2Ugb24gR0xLCj4gYW5kIENOTCAoYW5kIHNpbXBs aWZ5IHRoZSBzZWNvbmQgcGl4ZWxfcmF0ZSBjYWxjdWxhdGlvbikuCj4gCj4gLS1JbXJlCj4gCj4g PiAKPiA+ID4gQEAgLTE5MjksNiArMTkzOSw0MCBAQCBzdGF0aWMgaW50IGJ4dF9tb2Rlc2V0X2Nh bGNfY2RjbGsoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ID4gPiAgCXJldHVybiAw Owo+ID4gPiAgfQo+ID4gPiAgCj4gPiA+ICtzdGF0aWMgaW50IGNubF9tb2Rlc2V0X2NhbGNfY2Rj bGsoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ID4gPiArewo+ID4gPiArCXN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoc3RhdGUtPmRldik7Cj4gPiA+ ICsJc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqaW50ZWxfc3RhdGUgPQo+ID4gPiArCQl0b19p bnRlbF9hdG9taWNfc3RhdGUoc3RhdGUpOwo+ID4gPiArCWludCBtYXhfcGl4Y2xrID0gaW50ZWxf bWF4X3BpeGVsX3JhdGUoc3RhdGUpOwo+ID4gPiArCWludCBjZGNsaywgdmNvOwo+ID4gPiArCj4g PiA+ICsJY2RjbGsgPSBjbmxfY2FsY19jZGNsayhtYXhfcGl4Y2xrKTsKPiA+ID4gKwl2Y28gPSBj bmxfY2RjbGtfcGxsX3ZjbyhkZXZfcHJpdiwgY2RjbGspOwo+ID4gPiArCj4gPiA+ICsJaWYgKGNk Y2xrID4gZGV2X3ByaXYtPm1heF9jZGNsa19mcmVxKSB7Cj4gPiA+ICsJCURSTV9ERUJVR19LTVMo InJlcXVlc3RlZCBjZGNsayAoJWQga0h6KSBleGNlZWRzIG1heCAoJWQga0h6KVxuIiwKPiA+ID4g KwkJCSAgICAgIGNkY2xrLCBkZXZfcHJpdi0+bWF4X2NkY2xrX2ZyZXEpOwo+ID4gPiArCQlyZXR1 cm4gLUVJTlZBTDsKPiA+ID4gKwl9Cj4gPiA+ICsKPiA+ID4gKwlpbnRlbF9zdGF0ZS0+Y2RjbGsu bG9naWNhbC52Y28gPSB2Y287Cj4gPiA+ICsJaW50ZWxfc3RhdGUtPmNkY2xrLmxvZ2ljYWwuY2Rj bGsgPSBjZGNsazsKPiA+ID4gKwo+ID4gPiArCWlmICghaW50ZWxfc3RhdGUtPmFjdGl2ZV9jcnRj cykgewo+ID4gPiArCQljZGNsayA9IGNubF9jYWxjX2NkY2xrKDApOwo+ID4gPiArCQl2Y28gPSBj bmxfY2RjbGtfcGxsX3ZjbyhkZXZfcHJpdiwgY2RjbGspOwo+ID4gPiArCj4gPiA+ICsJCWludGVs X3N0YXRlLT5jZGNsay5hY3R1YWwudmNvID0gdmNvOwo+ID4gPiArCQlpbnRlbF9zdGF0ZS0+Y2Rj bGsuYWN0dWFsLmNkY2xrID0gY2RjbGs7Cj4gPiA+ICsJfSBlbHNlIHsKPiA+ID4gKwkJaW50ZWxf c3RhdGUtPmNkY2xrLmFjdHVhbCA9Cj4gPiA+ICsJCQlpbnRlbF9zdGF0ZS0+Y2RjbGsubG9naWNh bDsKPiA+ID4gKwl9Cj4gPiA+ICsKPiA+ID4gKwlyZXR1cm4gMDsKPiA+ID4gK30KPiA+ID4gKwo+ ID4gPiAgc3RhdGljIGludCBpbnRlbF9jb21wdXRlX21heF9kb3RjbGsoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gPiAgewo+ID4gPiAgCWludCBtYXhfY2RjbGtfZnJlcSA9 IGRldl9wcml2LT5tYXhfY2RjbGtfZnJlcTsKPiA+ID4gQEAgLTE5NjAsNyArMjAwNCw5IEBAIHN0 YXRpYyBpbnQgaW50ZWxfY29tcHV0ZV9tYXhfZG90Y2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdikKPiA+ID4gICAqLwo+ID4gPiAgdm9pZCBpbnRlbF91cGRhdGVfbWF4X2NkY2xr KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ID4gIHsKPiA+ID4gLQlpZiAo SVNfR0VOOV9CQyhkZXZfcHJpdikpIHsKPiA+ID4gKwlpZiAoSVNfQ0FOTk9OTEFLRShkZXZfcHJp dikpIHsKPiA+ID4gKwkJZGV2X3ByaXYtPm1heF9jZGNsa19mcmVxID0gNTI4MDAwOwo+ID4gPiAr CX0gZWxzZSBpZiAoSVNfR0VOOV9CQyhkZXZfcHJpdikpIHsKPiA+ID4gIAkJdTMyIGxpbWl0ID0g STkxNV9SRUFEKFNLTF9ERlNNKSAmIFNLTF9ERlNNX0NEQ0xLX0xJTUlUX01BU0s7Cj4gPiA+ICAJ CWludCBtYXhfY2RjbGssIHZjbzsKPiA+ID4gIAo+ID4gPiBAQCAtMjE1Nyw2ICsyMjAzLDEwIEBA IHZvaWQgaW50ZWxfaW5pdF9jZGNsa19ob29rcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYpCj4gPiA+ICAJCWRldl9wcml2LT5kaXNwbGF5LnNldF9jZGNsayA9IHNrbF9zZXRfY2Rj bGs7Cj4gPiA+ICAJCWRldl9wcml2LT5kaXNwbGF5Lm1vZGVzZXRfY2FsY19jZGNsayA9Cj4gPiA+ ICAJCQlza2xfbW9kZXNldF9jYWxjX2NkY2xrOwo+ID4gPiArCX0gZWxzZSBpZiAoSVNfQ0FOTk9O TEFLRShkZXZfcHJpdikpIHsKPiA+ID4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuc2V0X2NkY2xrID0g Y25sX3NldF9jZGNsazsKPiA+ID4gKwkJZGV2X3ByaXYtPmRpc3BsYXkubW9kZXNldF9jYWxjX2Nk Y2xrID0KPiA+ID4gKwkJCWNubF9tb2Rlc2V0X2NhbGNfY2RjbGs7Cj4gPiA+ICAJfQo+ID4gPiAg Cj4gPiA+ICAJaWYgKElTX0NBTk5PTkxBS0UoZGV2X3ByaXYpKQo+ID4gPiAtLSAKPiA+ID4gMS45 LjEKPiA+IAo+ID4gLS0gCj4gPiBWaWxsZSBTeXJqw6Rsw6QKPiA+IEludGVsIE9UQwoKLS0gClZp bGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==