All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Florian Vaussard <florian.vaussard@epfl.ch>,
	linux-omap <linux-omap@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Sekhar Nori <nsekhar@ti.com>
Subject: Re: [PATCH] ARM: dts: omap3-overo: Remove "vqmmc-supply" property from MMC dt node
Date: Sat, 10 Jun 2017 01:44:27 -0700	[thread overview]
Message-ID: <20170610084426.GM3730@atomide.com> (raw)
In-Reply-To: <275a0313-2cda-2328-e9e1-32bc91aca701@ti.com>

* Kishon Vijay Abraham I <kishon@ti.com> [170609 04:05]:
> Hi,
> 
> On Friday 09 June 2017 04:07 PM, Ulf Hansson wrote:
> > On 9 June 2017 at 10:41, Kishon Vijay Abraham I <kishon@ti.com> wrote:
> >> commit 94647a30124e2c7 ("ARM: dts: omap3-overo: Enable WiFi/BT combo")
> >> while enabling WiFi/BT combo added regulator to trigger the nReset
> >> signal of the Bluetooth module in vqmmc-supply. However BT should be
> >> handled by UART. Moreover "vqmmc" is not a defined binding for
> >> omap_hsmmc. While "vqmmc" in mmc2 hasn't caused any issues so far,
> >> mmc2 will start to mis-behave once omap_hsmmc defines "vqmmc"
> >> binding.
> >>
> >> Remove "vqmmc-supply" property in mmc2 here.
> >>
> >> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> > 
> > Okay, so I assume I also need to carry this in my immutable branch for
> > the omap driver changes. More precisely before the driver changes?
> 
> yeah, that's right!

As far as I can tell this regulator won't do anything right now so:

Acked-by: Tony Lindgren <tony@atomide.com>

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: omap3-overo: Remove "vqmmc-supply" property from MMC dt node
Date: Sat, 10 Jun 2017 01:44:27 -0700	[thread overview]
Message-ID: <20170610084426.GM3730@atomide.com> (raw)
In-Reply-To: <275a0313-2cda-2328-e9e1-32bc91aca701@ti.com>

* Kishon Vijay Abraham I <kishon@ti.com> [170609 04:05]:
> Hi,
> 
> On Friday 09 June 2017 04:07 PM, Ulf Hansson wrote:
> > On 9 June 2017 at 10:41, Kishon Vijay Abraham I <kishon@ti.com> wrote:
> >> commit 94647a30124e2c7 ("ARM: dts: omap3-overo: Enable WiFi/BT combo")
> >> while enabling WiFi/BT combo added regulator to trigger the nReset
> >> signal of the Bluetooth module in vqmmc-supply. However BT should be
> >> handled by UART. Moreover "vqmmc" is not a defined binding for
> >> omap_hsmmc. While "vqmmc" in mmc2 hasn't caused any issues so far,
> >> mmc2 will start to mis-behave once omap_hsmmc defines "vqmmc"
> >> binding.
> >>
> >> Remove "vqmmc-supply" property in mmc2 here.
> >>
> >> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> > 
> > Okay, so I assume I also need to carry this in my immutable branch for
> > the omap driver changes. More precisely before the driver changes?
> 
> yeah, that's right!

As far as I can tell this regulator won't do anything right now so:

Acked-by: Tony Lindgren <tony@atomide.com>

  reply	other threads:[~2017-06-10  8:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09  8:41 [PATCH] ARM: dts: omap3-overo: Remove "vqmmc-supply" property from MMC dt node Kishon Vijay Abraham I
2017-06-09  8:41 ` Kishon Vijay Abraham I
2017-06-09  8:41 ` Kishon Vijay Abraham I
     [not found] ` <20170609084141.15582-1-kishon-l0cyMroinI0@public.gmane.org>
2017-06-09 10:37   ` Ulf Hansson
2017-06-09 10:37     ` Ulf Hansson
2017-06-09 10:37     ` Ulf Hansson
2017-06-09 11:02     ` Kishon Vijay Abraham I
2017-06-09 11:02       ` Kishon Vijay Abraham I
2017-06-09 11:02       ` Kishon Vijay Abraham I
2017-06-10  8:44       ` Tony Lindgren [this message]
2017-06-10  8:44         ` Tony Lindgren
2017-06-12  7:58 ` Ulf Hansson
2017-06-12  7:58   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170610084426.GM3730@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.vaussard@epfl.ch \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.