Re: [PATCH] staging: vboxvideo: Add vboxvideo to drivers/staging

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sat, Jun 10, 2017 at 03:07:14PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 09-06-17 11:58, Hans de Goede wrote:
> > This commit adds the vboxvideo drm/kms driver for the virtual graphics
> > card used in Virtual Box virtual machines to drivers/staging.
> > 
> > Why drivers/staging? This driver is already being patched into the kernel
> > by several distros, thus it is good to get this driver upstream soon, so
> > that work on the driver can be easily shared.
> > 
> > At the same time we want to take our time to get this driver properly
> > cleaned up before submitting it as a normal driver under drivers/gpu/drm,
> > putting this driver in staging for now allows both.
> > 
> > Note this driver has already been significantly cleaned up, when I started
> > working on this the files under /usr/src/vboxguest/vboxvideo as installed
> > by Virtual Box 5.1.18 Guest Additions had a total linecount of 52681
> > lines. The version in this commit has 7275 lines.
> > 
> > Of those 7275 lines 3980 lines are in an osindependent directory which
> > contains portable code which is shared with other guest platforms such as
> > C-structure definitions for the virtual graphics card protocol and helper
> > functions for using these structures to communicate with the card. Since
> > these files are shared they are in the standard Virtual Box upstream code
> > style and not in the kernel coding style. All files outside of the
> > osindependent directory fully adhere to the kernel coding style.
> > 
> > Cc: vbox-dev@virtualbox.org
> > Cc: Michael Thayer <michael.thayer@oracle.com>
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > ---
> >   .config                                            |    1 +
> 
> <ugh> I just noticed that a .config changes have managed
> to get added to this patch, sorry.
> 
> Greg, lt me know if you want a new version if you can fix this
> up locally.

New version please!
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel