All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH v2] staging: lustre: llite: Replace the symbolic file permission mode with the numeric one
Date: Sun, 11 Jun 2017 09:44:41 +0200	[thread overview]
Message-ID: <20170611074441.GA30102@kroah.com> (raw)
In-Reply-To: <20170608172541.GA2314@home>

On Sat, Jun 10, 2017 at 02:48:34PM +0300, Roman Storozhenko wrote:
> Replaces S_IRWXUGO with 0777. The reason is that symbolic permissions
> considered harmful:
> https://lwn.net/Articles/696229/
> 
> The second version of that patch fixes the mistype in the first version.
> There were "0007" in the description instead of correct "0777" value.
> Thanks to Cory Spitz, who pointed out this error here:
> http://lists.lustre.org/pipermail/lustre-devel-lustre.org/2017-June/005726.html

This info doesn't need to be in the patch itself, it should go below the
--- line.

Please fix up and resend.

And also don't make your v3 of the patch with the same exact message-id
of the previous ones.  That's ripe for getting automatically deleted by
mail filters and email clients.

thanks,

greg k-h

      parent reply	other threads:[~2017-06-11  7:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08 17:25 [lustre-devel] [PATCH] staging: lustre: llite: Replace the symbolic file permission mode with the numeric one Roman Storozhenko
2017-06-09 20:13 ` Cory Spitz
2017-06-10 12:01   ` Roman Storozhenko
2017-06-11  7:44 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170611074441.GA30102@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=lustre-devel@lists.lustre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.