Re: [PATCH v1] iio: adc: ad7791: Use sysfs_match_string() helper

[Jonathan Cameron <jic23@kernel.org>]

On Fri,  9 Jun 2017 15:08:10 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> Use sysfs_match_string() helper instead of open coded variant.
> 
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Michael Hennerich <Michael.Hennerich@analog.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Looks obvious enough that I'm happy to apply without waiting
for Lars or Michael to have a moment.  It'll be in my testing
branch for at least a little while though if either of you
want to comment or add an Ack.

Thanks,

Jonathan
> ---
>  drivers/iio/adc/ad7791.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7791.c b/drivers/iio/adc/ad7791.c
> index 1817ebf5ad84..34e353c43ac8 100644
> --- a/drivers/iio/adc/ad7791.c
> +++ b/drivers/iio/adc/ad7791.c
> @@ -272,11 +272,9 @@ static ssize_t ad7791_write_frequency(struct device *dev,
>  	struct ad7791_state *st = iio_priv(indio_dev);
>  	int i, ret;
>  
> -	for (i = 0; i < ARRAY_SIZE(ad7791_sample_freq_avail); i++)
> -		if (sysfs_streq(ad7791_sample_freq_avail[i], buf))
> -			break;
> -	if (i == ARRAY_SIZE(ad7791_sample_freq_avail))
> -		return -EINVAL;
> +	i = sysfs_match_string(ad7791_sample_freq_avail, buf);
> +	if (i < 0)
> +		return i;
>  
>  	ret = iio_device_claim_direct_mode(indio_dev);
>  	if (ret)