All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Cc: michal.simek@xilinx.com, rajnikant.bhojani@xilinx.com,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: adc: xilinx-ams: add missing break in AMS_SUPPLY[78] cases
Date: Sun, 11 Jun 2017 14:58:31 +0100	[thread overview]
Message-ID: <20170611145831.040a2b45@kernel.org> (raw)
In-Reply-To: <1496776881-5265-1-git-send-email-jeff.dagenais@gmail.com>

On Tue,  6 Jun 2017 15:21:21 -0400
Jean-Francois Dagenais <jeff.dagenais@gmail.com> wrote:

> This would otherwise lead supply 7 and 8 to scale to 3V instead of
> 6V
> 
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Interesting... Driver isn't in mainline though and as far as I know
hasn't been submitted.

Jonathan
> ---
>  drivers/iio/adc/xilinx-ams.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
> index fd4eb6d..6b3ab56 100644
> --- a/drivers/iio/adc/xilinx-ams.c
> +++ b/drivers/iio/adc/xilinx-ams.c
> @@ -255,6 +255,7 @@ static int ams_read_raw(struct iio_dev *indio_dev,
>  			case AMS_SUPPLY7:
>  			case AMS_SUPPLY8:
>  				*val = AMS_SUPPLY_SCALE_6VOLT;
> +				break;
>  			case AMS_SUPPLY9:
>  			case AMS_SUPPLY10:
>  				if (chan->scan_index < PS_SEQ_MAX)


  reply	other threads:[~2017-06-11 13:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 19:21 [PATCH] iio: adc: xilinx-ams: add missing break in AMS_SUPPLY[78] cases Jean-Francois Dagenais
2017-06-11 13:58 ` Jonathan Cameron [this message]
2017-06-21 10:53   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170611145831.040a2b45@kernel.org \
    --to=jic23@kernel.org \
    --cc=jeff.dagenais@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=rajnikant.bhojani@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.