From: Denys Dmytriyenko <denis@denix.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [master][pyro][PATCH] bitbake.conf: Add whoami to HOSTTOOLS
Date: Sun, 11 Jun 2017 14:44:00 -0400 [thread overview]
Message-ID: <20170611184400.GP28053@denix.org> (raw)
In-Reply-To: <CAMKF1spiqofNf6r_0v6Hg208zH38x13-pX09e9OfCTbiGHEyBg@mail.gmail.com>
On Sun, Jun 11, 2017 at 10:22:58AM -0700, Khem Raj wrote:
> On Sun, Jun 11, 2017 at 9:58 AM, Jonathan Liu <net147@gmail.com> wrote:
> > The whoami command is used when building the Linux kernel in
> > scripts/mkcompile_h to embed the build user that is visible
> > in /proc/version.
> >
> > Signed-off-by: Jonathan Liu <net147@gmail.com>
> > ---
> > meta/conf/bitbake.conf | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index 3ad905c917..4f20aa3d1c 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -465,7 +465,7 @@ HOSTTOOLS += " \
> > mktemp mv nm objcopy objdump od patch perl pod2man pr printf pwd python python2 \
> > python2.7 python3 ranlib readelf readlink rm rmdir rpcgen sed sh sha256sum \
> > sleep sort split stat strings strip tail tar tee test touch tr true uname \
> > - uniq wc wget which xargs \
> > + uniq wc wget which whoami xargs \
>
> I think it might be better to not use whoami at all to begin with, it
> might be good for reproducibility too.
There was this whole discussion about adding whoami couple months ago -
Richard won't accept the change:
http://lists.openembedded.org/pipermail/openembedded-core/2017-March/134878.html
--
Denys
next prev parent reply other threads:[~2017-06-11 18:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-11 16:58 [master][pyro][PATCH] bitbake.conf: Add whoami to HOSTTOOLS Jonathan Liu
2017-06-11 17:22 ` Khem Raj
2017-06-11 18:44 ` Denys Dmytriyenko [this message]
2017-06-11 19:17 ` Burton, Ross
2017-06-11 19:59 ` Denys Dmytriyenko
2017-06-11 22:01 ` Richard Purdie
2017-06-11 22:04 ` Denys Dmytriyenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170611184400.GP28053@denix.org \
--to=denis@denix.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.