From: Tony Lindgren <tony@atomide.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: cpcap-usb: add MUSB dependency
Date: Mon, 12 Jun 2017 01:09:16 -0700 [thread overview]
Message-ID: <20170612080916.GV3730@atomide.com> (raw)
In-Reply-To: <7ebc90ce-3b0e-528b-3138-127a802637ea@ti.com>
* Kishon Vijay Abraham I <kishon@ti.com> [170609 05:04]:
>
>
> On Friday 09 June 2017 05:17 PM, Sebastian Reichel wrote:
> > Hi,
> >
> > On Fri, Jun 09, 2017 at 12:16:40PM +0200, Arnd Bergmann wrote:
> >> When MUSB is a loadable module, we get a link error for a built-in
> >> CPCAP driver:
> >>
> >> drivers/phy/built-in.o: In function `cpcap_usb_phy_remove':
> >> phy-cpcap-usb.c:(.text+0xed9): undefined reference to `musb_mailbox'
> >>
> >> This adds a Kconfig dependency to prevent this broken configuration,
> >> enforcing that CPCAP can only be a module when MUSB is also a module.
> >>
> >> Fixes: 68a1f7c9d470 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>
> merged, thanks!
Yup thanks for fixing it.
Regards,
Tony
prev parent reply other threads:[~2017-06-12 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 10:16 [PATCH] phy: cpcap-usb: add MUSB dependency Arnd Bergmann
2017-06-09 11:47 ` Sebastian Reichel
2017-06-09 12:00 ` Kishon Vijay Abraham I
2017-06-12 8:09 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612080916.GV3730@atomide.com \
--to=tony@atomide.com \
--cc=arnd@arndb.de \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.