From: Ralf Baechle <ralf@linux-mips.org>
To: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 00/11] MIPS: cmpxchg(), xchg() fixes & queued locks
Date: Mon, 12 Jun 2017 10:27:42 +0200 [thread overview]
Message-ID: <20170612082742.GA5642@linux-mips.org> (raw)
In-Reply-To: <20170610002644.8434-1-paul.burton@imgtec.com>
On Fri, Jun 09, 2017 at 05:26:32PM -0700, Paul Burton wrote:
> This series makes a bunch of cleanups & improvements to the cmpxchg() &
> xchg() macros & functions, allowing them to be used on values smaller
> than 4 bytes, then switches MIPS over to use generic queued spinlocks &
> queued read/write locks.
A number of nice cleanups there!
I'm wondering, have you tested the kernel size with and without this
series applied? GCC claims since 25 years or so that inlines are as
efficient as macros but in reality macros have always been superior
which mattered for things that are expanded very often.
More recent GCCs have claimed improvments so it'd be interested to see
actual numbers - and possibly get rid of many more unmaintainable macros.
Ralf
next prev parent reply other threads:[~2017-06-12 8:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-10 0:26 [PATCH 00/11] MIPS: cmpxchg(), xchg() fixes & queued locks Paul Burton
2017-06-10 0:26 ` Paul Burton
2017-06-10 0:26 ` [PATCH 01/11] MIPS: cmpxchg: Unify R10000_LLSC_WAR & non-R10000_LLSC_WAR cases Paul Burton
2017-06-10 0:26 ` Paul Burton
2017-06-10 23:25 ` Joshua Kinard
2017-06-12 19:02 ` Paul Burton
2017-06-12 19:02 ` Paul Burton
2017-06-10 0:26 ` [PATCH 02/11] MIPS: cmpxchg: Pull xchg() asm into a macro Paul Burton
2017-06-10 0:26 ` Paul Burton
2017-06-10 0:26 ` [PATCH 03/11] MIPS: cmpxchg: Use __compiletime_error() for bad cmpxchg() pointers Paul Burton
2017-06-10 0:26 ` Paul Burton
2017-06-10 0:26 ` [PATCH 04/11] MIPS: cmpxchg: Error out on unsupported xchg() calls Paul Burton
2017-06-10 0:26 ` Paul Burton
2017-06-10 0:26 ` [PATCH 05/11] MIPS: cmpxchg: Drop __xchg_u{32,64} functions Paul Burton
2017-06-10 0:26 ` Paul Burton
2017-06-10 0:26 ` [PATCH 06/11] MIPS: cmpxchg: Implement __cmpxchg() as a function Paul Burton
2017-06-10 0:26 ` Paul Burton
2017-06-10 0:26 ` [PATCH 07/11] MIPS: cmpxchg: Implement 1 byte & 2 byte xchg() Paul Burton
2017-06-10 0:26 ` Paul Burton
2017-06-10 0:26 ` [PATCH 08/11] MIPS: cmpxchg: Implement 1 byte & 2 byte cmpxchg() Paul Burton
2017-06-10 0:26 ` Paul Burton
2017-06-10 0:26 ` [PATCH 09/11] MIPS: cmpxchg: Rearrange __xchg() arguments to match xchg() Paul Burton
2017-06-10 0:26 ` Paul Burton
2017-06-10 0:26 ` [PATCH 10/11] MIPS: Use queued read/write locks (qrwlock) Paul Burton
2017-06-10 0:26 ` Paul Burton
2017-06-10 0:26 ` [PATCH 11/11] MIPS: Use queued spinlocks (qspinlock) Paul Burton
2017-06-10 0:26 ` Paul Burton
2020-11-06 16:28 ` Alexander Sverdlin
2017-06-12 8:27 ` Ralf Baechle [this message]
2017-06-12 22:47 ` [PATCH 00/11] MIPS: cmpxchg(), xchg() fixes & queued locks Paul Burton
2017-06-12 22:47 ` Paul Burton
2017-06-29 10:28 ` Joshua Kinard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612082742.GA5642@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.