Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging - Greg Kroah-Hartman

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	vbox-dev@virtualbox.org,
	Michael Thayer <michael.thayer@oracle.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging
Date: Mon, 12 Jun 2017 13:47:57 +0200	[thread overview]
Message-ID: <20170612114757.GA11629@kroah.com> (raw)
In-Reply-To: <20170612114409.GA11232@kroah.com>

On Mon, Jun 12, 2017 at 01:44:09PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de Goede wrote:
> > > The most important thing is for the driver to be atomic if it's KMS
> > > only, and it would be good to have someone review that properly.
> > 
> > I believe it does not use the atomic APIs atm, so that would be one
> > of the first things to fix then. Another question is if people
> > (you and Daniel at least) can live with the non kernel-coding
> > style shared files under the osindependent dir ?
> 
> Why not just spend a few days and fix up all of the kernel-style issues
> so it can be a "real" driver?  It shouldn't take all that long,
> especially for someone with Linux kernel experience (hint, hint...)
> 
> Only put stuff in staging for a good reason, and that reason can be "I
> don't know how to clean this stuff up", but I don't think that is the
> case here...

And why are you cc:ing a mailing list that does not accept non-members
to post?  that's just annoying...
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel