All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, matvejchikov@gmail.com, jblunck@infradead.org,
	sergio.gonzalez.monroy@intel.com, stable@dpdk.org
Subject: Re: [PATCH] eal: don't advertise a physical address when no hugepages
Date: Mon, 12 Jun 2017 15:58:57 +0200	[thread overview]
Message-ID: <20170612135857.GB1758@6wind.com> (raw)
In-Reply-To: <20170609082937.21294-1-olivier.matz@6wind.com>

On Fri, Jun 09, 2017 at 10:29:37AM +0200, Olivier Matz wrote:
> When populating a mempool with a virtual memory area, the mempool
> library expects to be able to get the physical address of each page.
> 
> When started with --no-huge, the physical addresses may not be available
> because the pages are not locked in memory. It sometimes returns
> RTE_BAD_PHYS_ADDR, which makes the mempool_populate() function to fail.
> 
> This was working before the commit cdc242f260e7 ("eal/linux: support
> running as unprivileged user"), because rte_mem_virt2phy() was returning
> 0 instead of RTE_BAD_PHYS_ADDR, which was seen as a valid physical
> address.
> 
> Since --no-huge is a debug function that breaks the support of physical
> drivers, always set physical addresses to RTE_BAD_PHYS_ADDR in memzones
> or in rte_mem_virt2phy(), and ensure that mempool won't complain in that
> case.
> 
> Fixes: cdc242f260e7 ("eal/linux: support running as unprivileged user")
> 
> CC: stable@dpdk.org
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Tested-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

-- 
Adrien Mazarguil
6WIND

  parent reply	other threads:[~2017-06-12 13:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-14 10:34 A (possible) problem with `--no-huge` option Ilya Matveychikov
2017-06-09  8:27 ` Olivier Matz
2017-06-09  8:29   ` [PATCH] eal: don't advertise a physical address when no hugepages Olivier Matz
2017-06-10  8:31     ` Jan Blunck
2017-06-23  8:11       ` Olivier Matz
2017-06-23 17:08         ` Jan Blunck
2017-06-26  7:11           ` santosh
2017-06-12 13:58     ` Adrien Mazarguil [this message]
2017-07-03 10:04     ` [PATCH v2] " Olivier Matz
2017-07-03 10:17       ` Jan Blunck
2017-07-04 15:53         ` [dpdk-stable] " Thomas Monjalon
2017-06-09 12:08   ` A (possible) problem with `--no-huge` option Ilya Matveychikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170612135857.GB1758@6wind.com \
    --to=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=jblunck@infradead.org \
    --cc=matvejchikov@gmail.com \
    --cc=olivier.matz@6wind.com \
    --cc=sergio.gonzalez.monroy@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.