From: Jiri Pirko <jiri@resnulli.us>
To: David Ahern <dsahern@gmail.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
davem@davemloft.net, netdev@vger.kernel.org,
xiyou.wangcong@gmail.com, eric.dumazet@gmail.com,
simon.horman@netronome.com, mrv@mojatatu.com
Subject: Re: [PATCH net-next v10 1/4] net netlink: Add new type NLA_FLAG_BITS
Date: Mon, 12 Jun 2017 21:22:38 +0200 [thread overview]
Message-ID: <20170612192238.GF1993@nanopsycho> (raw)
In-Reply-To: <80dd1bc2-80d6-d8fa-6032-d0641ae5d79b@gmail.com>
Mon, Jun 12, 2017 at 05:00:41PM CEST, dsahern@gmail.com wrote:
>On 6/12/17 8:14 AM, Jiri Pirko wrote:
>>>> The thing is, struct nla_flag_bits is tightly coupled with NLA_FLAG_BITS
>>>> enum value. They should be in the same uapi file. That makes sense to me.
>>>>
>>>
>>> Sure - they should be in the same file. But is it uapi/linux/netlink.h?
>>
>> Might be the netlink-types.h you mentioned above.
>>
>> ccing DavidA.
>>
>
>Just saw this patch set this morning. Few comments:
>
>1. I think nla_bitfield or nla_bitmap is a better name than nla_flag_bits
ack
>
>2. The length should be open ended with the size of the array determined
>by nla_len / sizeof(struct nla_bitfield). That allows this to be
>extended to an arbitrary large bitfield as needed.
Yeah, I was thinking about that as well. Seems handy to have this
generic len.
>
>3. IMO since these are nla prefixes and new NLA type they should be in
>uapi/linux/netlink.h
Including NLA_* type enum? I think it is reasonable.
next prev parent reply other threads:[~2017-06-12 19:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-11 11:53 [PATCH net-next v10 0/4] net sched actions: improve dump performance Jamal Hadi Salim
2017-06-11 11:53 ` [PATCH net-next v10 1/4] net netlink: Add new type NLA_FLAG_BITS Jamal Hadi Salim
2017-06-11 13:49 ` Jiri Pirko
2017-06-11 17:38 ` Jamal Hadi Salim
2017-06-11 18:37 ` Jamal Hadi Salim
2017-06-12 10:34 ` Jiri Pirko
2017-06-12 11:10 ` Jamal Hadi Salim
2017-06-12 11:43 ` Jiri Pirko
2017-06-12 13:51 ` Jamal Hadi Salim
2017-06-12 14:14 ` Jiri Pirko
2017-06-12 15:00 ` David Ahern
2017-06-12 19:22 ` Jiri Pirko [this message]
2017-06-12 19:58 ` David Ahern
2017-06-13 5:32 ` Jiri Pirko
2017-06-13 10:53 ` Jamal Hadi Salim
2017-06-13 11:25 ` Jiri Pirko
2017-06-13 13:58 ` David Ahern
2017-06-11 11:53 ` [PATCH net-next v10 2/4] net sched actions: Use proper root attribute table for actions Jamal Hadi Salim
2017-06-11 13:55 ` Jiri Pirko
2017-06-11 11:53 ` [PATCH net-next v10 3/4] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch Jamal Hadi Salim
2017-06-11 14:13 ` Jiri Pirko
2017-06-11 17:45 ` Jamal Hadi Salim
2017-06-12 11:16 ` Jamal Hadi Salim
2017-06-12 11:47 ` Jiri Pirko
2017-06-12 13:57 ` Jamal Hadi Salim
2017-06-12 14:16 ` Jiri Pirko
2017-06-11 11:53 ` [PATCH net-next v10 4/4] net sched actions: add time filter for action dumping Jamal Hadi Salim
2017-06-11 12:06 ` [PATCH net-next v10 0/4] net sched actions: improve dump performance Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612192238.GF1993@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@netronome.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.