From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/glm: fix musl build
Date: Mon, 12 Jun 2017 21:27:40 +0200 [thread overview]
Message-ID: <20170612212740.5ecd1524@windsurf.lan> (raw)
In-Reply-To: <20170612182936.8517-1-bernd.kuhls@t-online.de>
Hello,
On Mon, 12 Jun 2017 20:29:36 +0200, Bernd Kuhls wrote:
> The musl-related build error occurs because -pedantic is used for gcc
> which is broken with musl, for details refer to
> https://git.buildroot.net/buildroot/commit/package/jsoncpp?id=6b462ac8bd4021dda4f84198a127f1be7b46087d
>
> Glm uses this option only if GLM_TEST_ENABLE_LANG_EXTENSIONS=OFF, to
> solve the problem we set it to ON in order to use another code path
> in CMakeLists.txt which causes no other changes to compiler options
> because GLM_TEST_ENABLE_FAST_MATH defaults to OFF.
>
> To sum up, this patch only prevents -pedantic being added to gcc
> options which fixes
> http://autobuild.buildroot.net/results/890/8900d0c45c859edd95bb3610b224b9f222ef7493/
While I agree this works, it looks very, very fragile and clunky.
Shouldn't we patch out the -pedantic instead?
It's much more explicit and less likely to break.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-06-12 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 18:29 [Buildroot] [PATCH 1/1] package/glm: fix musl build Bernd Kuhls
2017-06-12 19:27 ` Thomas Petazzoni [this message]
2017-06-21 5:46 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612212740.5ecd1524@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.