Re: [morty/master][PATCH v3 1/3] qtwebbrowser: add QT web browser

From: Denys Dmytriyenko <denys@ti.com>
To: Eric Ruei <e-ruei1@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [morty/master][PATCH v3 1/3] qtwebbrowser: add QT web browser
Date: Mon, 12 Jun 2017 18:19:15 -0400	[thread overview]
Message-ID: <20170612221915.GI21219@edge> (raw)
In-Reply-To: <1496948064-3161-1-git-send-email-e-ruei1@ti.com>

Thanks, Eric, looks good. Please see below for a small comment.

On Thu, Jun 08, 2017 at 02:54:22PM -0400, Eric Ruei wrote:
> - This is a touch-friendly web broswer based on qtwebengine and QML
> 
> Signed-off-by: Eric Ruei <e-ruei1@ti.com>
> ---
>  .../recipes-qt/examples/qtwebbrowser_1.0.bb        | 34 ++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 meta-arago-extras/recipes-qt/examples/qtwebbrowser_1.0.bb
> 
> diff --git a/meta-arago-extras/recipes-qt/examples/qtwebbrowser_1.0.bb b/meta-arago-extras/recipes-qt/examples/qtwebbrowser_1.0.bb
> new file mode 100644
> index 0000000..c484bd9
> --- /dev/null
> +++ b/meta-arago-extras/recipes-qt/examples/qtwebbrowser_1.0.bb
> @@ -0,0 +1,34 @@
> +SUMMARY = "Qt Touch-Friendly WebBroswer"
> +HOMEPAGE = "http://blog.qt.io/blog/2016/07/18/qt-webbrowser-1-0/"
> +SECTION = "multimedia"
> +LICENSE = "GPL-3.0 & GFDL-1.3"
> +LIC_FILES_CHKSUM = " \
> +    file://LICENSE.GPLv3;md5=a40e2bb02b1ac431f461afd03ff9d1d6 \
> +    file://LICENSE.FDL;md5=6d9f2a9af4c8b8c3c769f6cc1b6aaf7e \
> +"
> +DEPENDS += "qtwebengine"
> +
> +PR = "r0"
> +
> +BRANCH = "dev"
> +SRCREV = "023733af5523a5ad84359926224fa106001215f4"
> +
> +SRC_URI = "git://code.qt.io/qt-apps/qtwebbrowser.git;protocol=git;branch=${BRANCH} \
> +"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit qt-provider
> +
> +# Install qtwebbrowser under /usr/bin
> +do_install() {
> +    install -d ${D}${bindir}
> +    install -d ${D}${datadir}/qt5/examples/webengine/webbrowser/src
> +    install -m 0755 src/qtwebbrowser ${D}${bindir}/qtwebbrowser
> +    cp -R --no-dereference --preserve=mode,links ${S}/* ${D}${datadir}/qt5/examples/webengine/webbrowser/.
> +}
> +
> +FILES_${PN} +=  " \
> +${bindir}/qtwebbrowser \
> +${datadir}/qt5/examples/webengine/webbrowser/* \
> +"

Can you please split the resulting package into ${PN} with only the binary and 
${PN}-examples with the sources? All you need to change is the FILES_ 
statements above. You can pull both into the packagegroup in patch #2. Thanks.

> -- 
> 1.9.1
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago