From: Kalle Valo <kvalo@codeaurora.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Hante Meuleman <hante.meuleman@broadcom.com>,
Christian Daudt <csd@broadcom.com>
Subject: Re: brcmfmac: Fix kernel oops on resume when request firmware fails.
Date: Tue, 13 Jun 2017 05:54:48 +0000 (UTC) [thread overview]
Message-ID: <20170613055448.C0CD36075B@smtp.codeaurora.org> (raw)
In-Reply-To: <20170523180733.26276-1-enric.balletbo@collabora.com>
Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote:
> When request firmware fails, brcmf_ops_sdio_remove is being called and
> brcmf_bus freed. In such circumstancies if you do a suspend/resume cycle
> the kernel hangs on resume due a NULL pointer dereference in resume
> function.
>
> Steps to reproduce the problem:
> - modprobe brcmfmac without the firmware
> brcmfmac mmc1:0001:1: Direct firmware load for brcm/brcmfmac4354-sdio.bin
> failed with error -2
> - do a suspend/resume cycle (echo mem > /sys/power/state)
>
> Protect against the NULL pointer derefence by checking if dev_get_drvdata
> returned a valid pointer.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
My understanding is that there's a new version of this patch which fixes
the issue. If not, let me know.
Patch set to Superseded.
--
https://patchwork.kernel.org/patch/9743159/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2017-06-13 5:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 18:07 [PATCH] brcmfmac: Fix kernel oops on resume when request firmware fails Enric Balletbo i Serra
2017-05-23 20:32 ` Franky Lin
2017-06-13 5:54 ` Kalle Valo [this message]
2017-06-13 10:23 ` Enric Balletbo Serra
2017-06-13 10:58 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613055448.C0CD36075B@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=csd@broadcom.com \
--cc=enric.balletbo@collabora.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.