From: Florian Westphal <fw@strlen.de>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
netfilter-devel@vger.kernel.org,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH nf-next] netns: add and use net_ns_barrier
Date: Tue, 13 Jun 2017 08:16:56 +0200 [thread overview]
Message-ID: <20170613061656.GF18283@breakpoint.cc> (raw)
In-Reply-To: <CAM_iQpXgrQcbrQsMVoomcsHtk4JffRjJ27FLRoignndAzFVkug@mail.gmail.com>
Cong Wang <xiyou.wangcong@gmail.com> wrote:
> On Thu, Jun 1, 2017 at 1:52 AM, Florian Westphal <fw@strlen.de> wrote:
> > Joe described it nicely, problem is that after unload we may have
> > conntracks that still have a nf_conn_help extension attached that
> > has a pointer to a structure that resided in the (unloaded) module.
>
> Why not hold a refcnt for its module?
That would work as well.
I'm not sure its nice to disallow rmmod of helper modules if they are
used by a connection however.
Right now you can "rmmod nf_conntrack_foo" at any time and this should
work just fine without first having to flush affected conntracks
manually.
next prev parent reply other threads:[~2017-06-13 6:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 9:38 [PATCH nf-next] netns: add and use net_ns_barrier Florian Westphal
2017-05-31 16:55 ` David Miller
2017-05-31 17:46 ` Eric W. Biederman
2017-05-31 18:13 ` Eric W. Biederman
2017-05-31 20:21 ` Joe Stringer
2017-06-01 8:52 ` Florian Westphal
2017-06-12 21:47 ` Cong Wang
2017-06-13 6:16 ` Florian Westphal [this message]
2017-06-13 16:35 ` Cong Wang
2017-06-13 18:07 ` Florian Westphal
2017-06-13 19:27 ` Joe Stringer
2017-06-13 21:16 ` Cong Wang
2017-06-14 8:41 ` Pablo Neira Ayuso
2017-06-14 14:20 ` Eric W. Biederman
2017-06-12 8:47 ` Pablo Neira Ayuso
2017-06-02 9:38 ` David Laight
2017-06-02 9:53 ` Florian Westphal
2017-06-19 17:10 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613061656.GF18283@breakpoint.cc \
--to=fw@strlen.de \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.