From: Kalle Valo <kvalo@codeaurora.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Igor Mitsyanko <imitsyanko@quantenna.com>,
Avinash Patil <avinashp@quantenna.com>,
Sergey Matyukevich <smatyukevich@quantenna.com>,
Dmitrii Lebed <dlebed@quantenna.com>,
Huizhao Wang <hwang@quantenna.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [wireless-next] qtnfmac: check band before allocating cmd_skb to avoid resource leak
Date: Tue, 13 Jun 2017 07:02:13 +0000 [thread overview]
Message-ID: <20170613070213.64C55606DC@smtp.codeaurora.org> (raw)
In-Reply-To: <20170602154045.28948-1-colin.king@canonical.com>
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The current code allocates cmd_skb and then will leak this if band->band
> is an illegal value. It is simpler to sanity check the band first before
> allocating cmd_skb so that we don't have to free cmd_skb if an invalid
> band occurs.
>
> Detected by CoverityScan, CID#1437561 ("Resource Leak")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
Patch applied to wireless-drivers-next.git, thanks.
bc0384eedb66 qtnfmac: check band before allocating cmd_skb to avoid resource leak
--
https://patchwork.kernel.org/patch/9762863/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Igor Mitsyanko <imitsyanko@quantenna.com>,
Avinash Patil <avinashp@quantenna.com>,
Sergey Matyukevich <smatyukevich@quantenna.com>,
Dmitrii Lebed <dlebed@quantenna.com>,
Huizhao Wang <hwang@quantenna.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [wireless-next] qtnfmac: check band before allocating cmd_skb to avoid resource leak
Date: Tue, 13 Jun 2017 07:02:13 +0000 (UTC) [thread overview]
Message-ID: <20170613070213.64C55606DC@smtp.codeaurora.org> (raw)
In-Reply-To: <20170602154045.28948-1-colin.king@canonical.com>
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The current code allocates cmd_skb and then will leak this if band->band
> is an illegal value. It is simpler to sanity check the band first before
> allocating cmd_skb so that we don't have to free cmd_skb if an invalid
> band occurs.
>
> Detected by CoverityScan, CID#1437561 ("Resource Leak")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
Patch applied to wireless-drivers-next.git, thanks.
bc0384eedb66 qtnfmac: check band before allocating cmd_skb to avoid resource leak
--
https://patchwork.kernel.org/patch/9762863/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2017-06-13 7:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 15:40 [PATCH][wireless-next] qtnfmac: check band before allocating cmd_skb to avoid resource leak Colin King
2017-06-02 15:40 ` Colin King
2017-06-02 17:32 ` Igor Mitsyanko
2017-06-02 17:32 ` Igor Mitsyanko
2017-06-13 7:02 ` Kalle Valo [this message]
2017-06-13 7:02 ` [wireless-next] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613070213.64C55606DC@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=avinashp@quantenna.com \
--cc=colin.king@canonical.com \
--cc=dlebed@quantenna.com \
--cc=hwang@quantenna.com \
--cc=imitsyanko@quantenna.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=smatyukevich@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.