All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Aviya Erenfeld <aviyae42@gmail.com>
Cc: goudapatilk@gmail.com, insafonov@gmail.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] staging: rtl8188eu: Remove redundant parenthesis
Date: Tue, 13 Jun 2017 11:22:46 +0200	[thread overview]
Message-ID: <20170613092246.GC5677@kroah.com> (raw)
In-Reply-To: <bae7535b-69f4-18e7-5b04-a6d32c8d3108@gmail.com>

On Tue, Jun 13, 2017 at 08:50:38AM +0300, Aviya Erenfeld wrote:
> Remove redundant parenthesis
> 
> Signed-off-by: Aviya Erenfeld <aviyae42@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> index 2ecfb11..c6a7df5 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> @@ -91,7 +91,7 @@ u32	_rtw_init_sta_priv(struct	sta_priv *pstapriv)
>  	for (i = 0; i < NUM_STA; i++) {
>  		_rtw_init_stainfo(psta);
>  
> -		INIT_LIST_HEAD(&(pstapriv->sta_hash[i]));
> +		INIT_LIST_HEAD(&pstapriv->sta_hash[i]);

What complaines about these?  Does checkpatch?  Or something else?

It makes sense why they were added, don't you think so?  It makes the
code easier to understand in some places.

thanks,

greg k-h

  reply	other threads:[~2017-06-13  9:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-13  5:49 [PATCH v2 0/3] Fix some style issues Aviya Erenfeld
2017-06-13  5:50 ` [PATCH v2 1/3] staging: rtl8188eu: Remove redundant parenthesis Aviya Erenfeld
2017-06-13  9:22   ` Greg KH [this message]
2017-06-13  5:51 ` [PATCH v2 2/3] staging: rtl8188eu: Remove unneeded blank lines Aviya Erenfeld
2017-06-13  5:52 ` [PATCH v2 3/3] staging: rtl8188eu: Shorten lines over 80 chars Aviya Erenfeld
2017-06-13  6:03   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170613092246.GC5677@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=aviyae42@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=goudapatilk@gmail.com \
    --cc=insafonov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.