From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Cc: Johan Hovold <johan@kernel.org>, Jiri Slaby <jslaby@suse.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Samuel Ortiz <samuel@sortiz.org>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code
Date: Tue, 13 Jun 2017 11:48:41 +0200 [thread overview]
Message-ID: <20170613094841.GA31846@kroah.com> (raw)
In-Reply-To: <20170606122704.3e328125@lxorguk.ukuu.org.uk>
On Tue, Jun 06, 2017 at 12:27:04PM +0100, Alan Cox wrote:
> On Tue, 6 Jun 2017 12:54:40 +0200
> Johan Hovold <johan@kernel.org> wrote:
>
> > Remove three ifdefed and broken implementations of TIOCSSERIAL and
> > TIOCGICOUNT, and parity handling in set_termios which had suffered
> > severe bit rot.
>
> I would be amazed if the IRDA code still works. It's not been tested
> properly for years and it never followed the tty rules properly in the
> first place - so this looks good, although moving IRDA into staging
> and /dev/null would IMHO be far better.
>
> IRDA is dead, and IR remotes are handled via completely different code.
I agree, and we should move it into staging and out of the tree, I'll
send netdev some patches for that...
thanks,
greg k-h
next prev parent reply other threads:[~2017-06-13 9:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 10:54 [PATCH 0/9] tty: drop broken alt-speed handling Johan Hovold
2017-06-06 10:54 ` [PATCH 1/9] serial: rate limit custom-speed deprecation notice Johan Hovold
2017-06-06 10:54 ` [PATCH 2/9] USB: serial: ftdi_sio: simplify TIOCSSERIAL flag logic Johan Hovold
2017-06-06 10:54 ` [PATCH 3/9] USB: serial: ftdi_sio: remove broken alt-speed handling Johan Hovold
2017-06-06 10:54 ` [PATCH 4/9] tty: simserial: drop unused alt_speed handling Johan Hovold
2017-06-06 10:54 ` [PATCH 5/9] tty: amiserial: drop broken alt-speed support Johan Hovold
2017-06-06 10:54 ` [PATCH 6/9] tty: cyclades: " Johan Hovold
2017-06-06 10:54 ` [PATCH 7/9] tty: rocket: " Johan Hovold
2017-06-06 10:54 ` [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code Johan Hovold
2017-06-06 11:27 ` Alan Cox
2017-06-13 9:48 ` Greg Kroah-Hartman [this message]
2017-06-13 9:57 ` Johan Hovold
2017-06-13 10:00 ` Johan Hovold
2017-06-13 10:01 ` Greg Kroah-Hartman
2017-06-06 10:54 ` [PATCH 9/9] tty: drop unused alt_speed from tty_struct Johan Hovold
2017-06-06 11:29 ` [PATCH 0/9] tty: drop broken alt-speed handling Alan Cox
2017-06-07 9:53 ` Andy Shevchenko
2017-06-13 9:55 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613094841.GA31846@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=fenghua.yu@intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=johan@kernel.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=samuel@sortiz.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.