From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Tissoires Subject: Re: [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI Date: Tue, 13 Jun 2017 12:06:17 +0200 Message-ID: <20170613100617.GD29589@mail.corp.redhat.com> References: <20170601184632.2980-1-benjamin.tissoires@redhat.com> <20170607074848.GE27006@gardel-login> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170607074848.GE27006@gardel-login> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: systemd-devel-bounces@lists.freedesktop.org Sender: "systemd-devel" To: Lennart Poettering Cc: Len Brown , systemd-devel@lists.freedesktop.org, linux-acpi@vger.kernel.org, "Rafael J . Wysocki" , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, Lv Zheng , Lv Zheng , linux-input@vger.kernel.org List-Id: linux-acpi@vger.kernel.org SGksCgpbU29ycnkgZm9yIHRoZSBkZWxheSwgSSBoYXZlIGJlZW4gc2lkZXRyYWNrZWQgZnJvbSB0 aGlzXQoKT24gSnVuIDA3IDIwMTcgb3IgdGhlcmVhYm91dHMsIExlbm5hcnQgUG9ldHRlcmluZyB3 cm90ZToKPiBPbiBUaHUsIDAxLjA2LjE3IDIwOjQ2LCBCZW5qYW1pbiBUaXNzb2lyZXMgKGJlbmph bWluLnRpc3NvaXJlc0ByZWRoYXQuY29tKSB3cm90ZToKPiAKPiA+IEhpLAo+ID4gCj4gPiBTZW5k aW5nIHRoaXMgYXMgYSBXSVAgYXMgaXQgc3RpbGwgbmVlZCBhIGZldyBjaGFuZ2VzLCBidXQgaXQg bW9zdGx5IHdvcmtzIGFzCj4gPiBleHBlY3RlZCAoc3RpbGwgbm90IGZ1bGx5IGNvbXBsaWFudCB5 ZXQpLgo+ID4gCj4gPiBTbyB0aGlzIGlzIGJhc2VkIG9uIExlbm5hcnQncyBjb21tZW50IGluIFsx XTogaWYgdGhlIExJRCBzdGF0ZSBpcyBub3QgcmVsaWFibGUsCj4gPiB0aGUga2VybmVsIHNob3Vs ZCBub3QgZXhwb3J0IHRoZSBMSUQgc3dpdGNoIGRldmljZSBhcyBsb25nIGFzIHdlIGFyZSBub3Qg c3VyZQo+ID4gYWJvdXQgaXRzIHN0YXRlLgo+IAo+IEFoIG5pY2UhIEkgKG9idmlvdXNseSkgbGlr ZSB0aGlzIGFwcHJvYWNoLgoKSGVoLiBOb3cgSSBqdXN0IG5lZWQgdG8gY29udmluY2UgTHYgdGhh dCBpdCdzIHRoZSByaWdodCBhcHByb2FjaC4KCj4gCj4gPiBOb3RlIHRoYXQgc3lzdGVtZCBjdXJy ZW50bHkgZG9lc24ndCBzeW5jIHRoZSBzdGF0ZSB3aGVuIHRoZSBpbnB1dCBub2RlIGp1c3QKPiA+ IGFwcGVhcnMuIFRoaXMgaXMgYSBzeXN0ZW1kIGJ1ZywgYW5kIGl0IHNob3VsZCBub3QgYmUgaGFu ZGxlZCBieSB0aGUga2VybmVsCj4gPiBjb21tdW5pdHkuCj4gCj4gVWggaWYgdGhpcyBpcyBib3Jr ZWQsIHdlIHNob3VsZCBpbmRlZWQgZml4IHRoaXMgaW4gc3lzdGVtZC4gSXMgdGhlcmUKPiBhbHJl YWR5IGEgc3lzdGVtZCBnaXRodWIgYnVnIGFib3V0IHRoaXM/IElmIG5vdCwgcGxlYXNlIGNyZWF0 ZSBvbmUsCj4gYW5kIHdlJ2xsIGxvb2sgaW50byBpdCEKCkkgZG9uJ3QgdGhpbmsgdGhlcmUgaXMu IEkgaGF2ZW4ndCByYWlzZWQgaXQgeWV0IGJlY2F1c2UgSSBhbSBub3Qgc28gc3VyZQp0aGlzIHdp bGwgbm90IGJyZWFrIGFnYWluIHRob3NlIHdvcnRobGVzcyB1bnJlbGlhYmxlIExJRCwgYW5kIGlm IHdlIHBsYXkKd2hhY2sgYSBtb2xlIGJldHdlZW4gdGhlIGtlcm5lbCBhbmQgdXNlciBzcGFjZSwg dGhpbmdzIGFyZSBnb2luZyB0byBiZQpuYXN0eS4gU28gSSdkIHJhdGhlciBoYXZlIHRoaXMgZml4 ZWQgaW4gc3lzdGVtZCBhbG9uZyB3aXRoIHRoZQp1bnJlbGlhYmxlIExJRCBzd2l0Y2gga25vd2xl ZGdlLCBzbyB3ZSBhcmUgc3VyZSB0aGF0IHRoZSBrZXJuZWwgYmVoYXZlcwp0aGUgd2F5IHdlIGV4 cGVjdCBpdCB0byBiZS4KCj4gCj4gVGhhbmtzIGZvciB3b3JraW5nIG9uIHRoaXMsCj4gCgpObyB3 b3JyaWVzLgoKQ2hlZXJzLApCZW5qYW1pbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18Kc3lzdGVtZC1kZXZlbCBtYWlsaW5nIGxpc3QKc3lzdGVtZC1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9zeXN0ZW1kLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752962AbdFMKGb (ORCPT ); Tue, 13 Jun 2017 06:06:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52424 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752855AbdFMKG0 (ORCPT ); Tue, 13 Jun 2017 06:06:26 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D03D63DBED Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=benjamin.tissoires@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D03D63DBED Date: Tue, 13 Jun 2017 12:06:17 +0200 From: Benjamin Tissoires To: Lennart Poettering Cc: Lv Zheng , "Rafael J . Wysocki" , "Rafael J . Wysocki" , Len Brown , Lv Zheng , Peter Hutterer , linux-acpi@vger.kernel.org, systemd-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI Message-ID: <20170613100617.GD29589@mail.corp.redhat.com> References: <20170601184632.2980-1-benjamin.tissoires@redhat.com> <20170607074848.GE27006@gardel-login> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170607074848.GE27006@gardel-login> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 13 Jun 2017 10:06:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, [Sorry for the delay, I have been sidetracked from this] On Jun 07 2017 or thereabouts, Lennart Poettering wrote: > On Thu, 01.06.17 20:46, Benjamin Tissoires (benjamin.tissoires@redhat.com) wrote: > > > Hi, > > > > Sending this as a WIP as it still need a few changes, but it mostly works as > > expected (still not fully compliant yet). > > > > So this is based on Lennart's comment in [1]: if the LID state is not reliable, > > the kernel should not export the LID switch device as long as we are not sure > > about its state. > > Ah nice! I (obviously) like this approach. Heh. Now I just need to convince Lv that it's the right approach. > > > Note that systemd currently doesn't sync the state when the input node just > > appears. This is a systemd bug, and it should not be handled by the kernel > > community. > > Uh if this is borked, we should indeed fix this in systemd. Is there > already a systemd github bug about this? If not, please create one, > and we'll look into it! I don't think there is. I haven't raised it yet because I am not so sure this will not break again those worthless unreliable LID, and if we play whack a mole between the kernel and user space, things are going to be nasty. So I'd rather have this fixed in systemd along with the unreliable LID switch knowledge, so we are sure that the kernel behaves the way we expect it to be. > > Thanks for working on this, > No worries. Cheers, Benjamin